You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2018/05/31 22:03:51 UTC
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10562
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
IMPALA-7099: fix test_unsupported_text_compression delete path
Looks like this test was meaning to delete the path at TBL_LOCATION,
not TBL_NAME.
Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
---
M tests/metadata/test_partition_metadata.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/10562/1
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10562 )
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py@62
PS1, Line 62: self.filesystem_client.delete_file_dir(TBL_NAME, recursive=True)
This also seems to have the same mistake.
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 22:16:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10562
to look at the new patch set (#2).
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
IMPALA-7099: fix test_unsupported_text_compression delete path
Looks like this test was meaning to delete the path at TBL_LOCATION,
not TBL_NAME.
Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
---
M tests/metadata/test_partition_metadata.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/10562/2
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has abandoned this change. ( http://gerrit.cloudera.org:8080/10562 )
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
Abandoned
There is more going on here - see JIRA for details. Will repost a new patch later.
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10562 )
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
Patch Set 1:
(1 comment)
As we discussed offline, this doesn't seem to be the root problem though given the assert is saying there are not enough files.
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py@62
PS1, Line 62: self.filesystem_client.delete_file_dir(TBL_NAME, recursive=True)
> This also seems to have the same mistake.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 22:51:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7099: fix test unsupported text compression delete path
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10562 )
Change subject: IMPALA-7099: fix test_unsupported_text_compression delete path
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:
http://gerrit.cloudera.org:8080/#/c/10562/1/tests/metadata/test_partition_metadata.py@220
PS1, Line 220: [1:]
this seems wrong if FILESYSTEM_PREFIX is not empty.
--
To view, visit http://gerrit.cloudera.org:8080/10562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I564760c9eaa63514f2b59c250b4b000b7a960601
Gerrit-Change-Number: 10562
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 22:52:16 +0000
Gerrit-HasComments: Yes