You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/16 06:04:39 UTC

[GitHub] sijie commented on a change in pull request #1266: Fixed buffer release in v2 BookieProtocol

sijie commented on a change in pull request #1266: Fixed buffer release in v2 BookieProtocol
URL: https://github.com/apache/bookkeeper/pull/1266#discussion_r175003997
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -1138,6 +1138,7 @@ static ReadV2ResponseCallback create(CompletionValue completionValue, long ledge
         @Override
         public void safeRun() {
             completionValue.handleV2Response(ledgerId, entryId, status, response);
+            response.release();
 
 Review comment:
   can we combine `release` and `recycle` like what we did for request?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services