You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2023/06/16 20:35:45 UTC

[GitHub] [airflow] shahar1 opened a new pull request, #31970: Remove airflow user from `Dockerfile.ci`

shahar1 opened a new pull request, #31970:
URL: https://github.com/apache/airflow/pull/31970

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Following discussion #31714 - I'm trying to remove `airflow` user from `Dockerfile.ci` and see how it affects it.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #31970: Remove the creation of `airflow` user from `Dockerfile.ci`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31970:
URL: https://github.com/apache/airflow/pull/31970#issuecomment-1679534537

   Ah... WE need to revert this one, It was actually used to enable ssh debugging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #31970: Remove the creation of `airflow` user from `Dockerfile.ci`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31970:
URL: https://github.com/apache/airflow/pull/31970#issuecomment-1595656128

   Set the "full tests needed" and rebased - to see if there is no missed tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #31970: Remove the creation of `airflow` user from `Dockerfile.ci`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31970:
URL: https://github.com/apache/airflow/pull/31970#issuecomment-1595952649

   All looks good :). Seems it was indeed a thing of a past.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #31970: Remove the creation of `airflow` user from `Dockerfile.ci`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31970:
URL: https://github.com/apache/airflow/pull/31970


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org