[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #302: [FLINK-28297][FLINK-27914] Improve operator metric groups + Add JOSDK metric integration

[GitBox <gi...@apache.org>]

SteNicholas commented on PR #302:
URL: https://github.com/apache/flink-kubernetes-operator/pull/302#issuecomment-1178475779

   @gyfora, thanks for the improvement for JOSDK metrics. I have verified the  JOSDK metrics and the metrics look good to me.
   ```
   -- Counters -------------------------------------------------------------------
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.resource.default.basic-example.JOSDK.Resource.Event.Count: 1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.resource.default.basic-example.JOSDK.Reconciliation.finished.Count: 20
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.resource.default.basic-example.JOSDK.Resource.Event.ADDED.Count: 1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.resource.default.basic-example.JOSDK.Reconciliation.Count: 20
   
   -- Gauges ---------------------------------------------------------------------
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.Count: 1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.GarbageCollector.G1 Young Generation.Count: 4
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Direct.MemoryUsed: 16777225
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.READY.Count: 1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Mapped.TotalCapacity: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Mapped.MemoryUsed: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.GarbageCollector.G1 Old Generation.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Metaspace.Max: -1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.DEPLOYING.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Direct.TotalCapacity: 16777224
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.ERROR.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Heap.Max: 2061500416
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.NonHeap.Max: -1
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Direct.Count: 5
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.DEPLOYED_NOT_READY.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.GarbageCollector.G1 Old Generation.Time: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.NonHeap.Committed: 63680512
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Mapped.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.CPU.Load: 0.0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.GarbageCollector.G1 Young Generation.Time: 89
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.namespace.default.FlinkDeployment.MISSING.Count: 0
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.NonHeap.Used: 59893976
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.ClassLoader.ClassesUnloaded: 6
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.CPU.Time: 13130000000
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Heap.Committed: 132120576
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Metaspace.Committed: 43536384
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.ClassLoader.ClassesLoaded: 7894
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Threads.Count: 27
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Heap.Used: 71449296
   flink-kubernetes-operator-59fb9cfd78-2wwfm.k8soperator.default.flink-kubernetes-operator.system.Status.JVM.Memory.Metaspace.Used: 42010360
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org