[commons-compress] branch master updated: document COMPRESS-559 and make some comments

[pe...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

peterlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 4cf5b34  document COMPRESS-559 and make some comments
4cf5b34 is described below

commit 4cf5b340bfb881457fc03819f1b2a651c798c5af
Author: PeterAlfredLee <pe...@gmail.com>
AuthorDate: Thu Dec 10 14:56:49 2020 +0800

    document COMPRESS-559 and make some comments
---
 src/changes/changes.xml                                             | 6 ++++++
 .../org/apache/commons/compress/archivers/tar/SparseFilesTest.java  | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 6406761..59aa94e 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -277,6 +277,12 @@ The <action> type attribute can be add,update,fix,remove.
         true if the entry is a sparse entry.
         Github Pull Request #153.
       </action>
+      <action issue="COMPRESS-559" type="fix" date="2020-12-10"
+              due-to="Robin Schimpf" dev="Robin Schimpf">
+        SparseFilesTest#testExtractPaxGNU should be skipped
+        if the version of GNU tar binary is 1.28.
+        Github Pull Request #152.
+      </action>
     </release>
     <release version="1.20" date="2020-02-08"
              description="Release 1.20 (Java 7)">
diff --git a/src/test/java/org/apache/commons/compress/archivers/tar/SparseFilesTest.java b/src/test/java/org/apache/commons/compress/archivers/tar/SparseFilesTest.java
index ab41002..852455d 100644
--- a/src/test/java/org/apache/commons/compress/archivers/tar/SparseFilesTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/tar/SparseFilesTest.java
@@ -178,6 +178,9 @@ public class SparseFilesTest extends AbstractTestCase {
     @Test
     public void testExtractPaxGNU() throws IOException, InterruptedException {
         assumeFalse("This test should be ignored on Windows", isOnWindows);
+        // GNU tar with version 1.28 has some problems reading sparsefile-0.1,
+        // so the test should be skipped then
+        // TODO : what about the versions lower than 1.28?
         assumeFalse("This test should be ignored if GNU tar is version 1.28",
                 getTarBinaryHelp().startsWith("tar (GNU tar) 1.28"));