You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ro...@apache.org on 2007/09/08 14:41:42 UTC

svn commit: r573830 - in /jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn: DefaultClientConnection.java DefaultClientConnectionOperator.java

Author: rolandw
Date: Sat Sep  8 05:41:42 2007
New Revision: 573830

URL: http://svn.apache.org/viewvc?rev=573830&view=rev
Log:
HTTPCORE-110: removed lineParser and lineFormatter attributes

Modified:
    jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java
    jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java

Modified: jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java?rev=573830&r1=573829&r2=573830&view=diff
==============================================================================
--- jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java (original)
+++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java Sat Sep  8 05:41:42 2007
@@ -171,8 +171,9 @@
             final SessionInputBuffer buffer,
             final HttpResponseFactory responseFactory, 
             final HttpParams params) {
+        // override in derived class to specify a line parser
         return new DefaultResponseParser
-            (buffer, getLineParser(), responseFactory, params);
+            (buffer, null, responseFactory, params);
     }
 
 

Modified: jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java?rev=573830&r1=573829&r2=573830&view=diff
==============================================================================
--- jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java (original)
+++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java Sat Sep  8 05:41:42 2007
@@ -36,7 +36,6 @@
 import java.net.InetAddress;
 
 import org.apache.http.HttpHost;
-import org.apache.http.message.LineParser;
 import org.apache.http.params.HttpParams;
 import org.apache.http.params.HttpConnectionParams;
 import org.apache.http.protocol.HttpContext;
@@ -70,12 +69,6 @@
     /** The scheme registry for looking up socket factories. */
     protected SchemeRegistry schemeRegistry;
 
-    /**
-     * The line parser to use for created connections.
-     * <code>null</code> indicates the default parser.
-     */
-    protected LineParser lineParser;
-
 
     /**
      * Creates a new client connection operator for the given scheme registry.
@@ -91,31 +84,9 @@
     }
 
 
-    /**
-     * Obtains the line parser to be used by the connections.
-     *
-     * @return  the line parser, or <code>null</code> for the default
-     */
-    public LineParser getLineParser() {
-        return lineParser;
-    }
-
-
-    /**
-     * Specifies the line parser to be used by the connections.
-     *
-     * @param parser    the line parser, or <code>null</code> for the default
-     */
-    public void setLineParser(LineParser parser) {
-        lineParser = parser;
-    }
-
-
     // non-javadoc, see interface ClientConnectionOperator
     public OperatedClientConnection createConnection() {
-        DefaultClientConnection dcc = new DefaultClientConnection();
-        dcc.setLineParser(lineParser);
-        return dcc;
+        return new DefaultClientConnection();
     }