You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/03/07 18:42:57 UTC

[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3475: [GOBBLIN-1617] pass configurations to some HadoopUtils APIs

arjun4084346 commented on a change in pull request #3475:
URL: https://github.com/apache/gobblin/pull/3475#discussion_r820997940



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/FsDataWriter.java
##########
@@ -96,7 +97,7 @@ public FsDataWriter(FsDataWriterBuilder<?, ?> builder, State properties) throws
     this.writerAttemptIdOptional = Optional.fromNullable(builder.getWriterAttemptId());
     this.encoders = builder.getEncoders();
 
-    Configuration conf = new Configuration();
+    this.conf = new Configuration();

Review comment:
       Line 102 might be doing the same thing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org