[jira] [Updated] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde updated CALCITE-3167:
---------------------------------
    Summary: Remove overriding equals and hashCode methods in EnumerableTableScan  (was: Remove redundant overriding methods of equals&hashcode in EnumerableTableScan.java)

> Remove overriding equals and hashCode methods in EnumerableTableScan
> --------------------------------------------------------------------
>
>                 Key: CALCITE-3167
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3167
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: jin xing
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In current code of EnumerableTableScan.java, methods of equals&hashCode are overrided for matching of EnumerableTableScans.
> While after optimizing with the same HEP planner, EnumerableTableScans from two plans but with the same digest will the share the same Java object.
>  [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java#L192]
>  I think it's ok to remove the redundant overriding methods in EnumerableTableScan.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)