[GitHub] [arrow] pitrou commented on a diff in pull request #36536: GH-36523: [C++] Fix TSan-detected lock ordering issues in S3

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #36536:
URL: https://github.com/apache/arrow/pull/36536#discussion_r1255508280


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1158,7 +1179,7 @@ class ObjectInputFile final : public io::RandomAccessFile {
     req.SetKey(ToAwsString(path_.key));
 
     ARROW_ASSIGN_OR_RAISE(auto client_lock, holder_->Lock());
-    auto outcome = client_lock->HeadObject(req);
+    auto outcome = std::move(client_lock)->HeadObject(req);

Review Comment:
   TBH I'm not sure if calling `std::move` here is enough to destroy `client_lock` at the end of this statement. @bkietz Can you advise?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org