You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nk1506 (via GitHub)" <gi...@apache.org> on 2024/02/28 11:24:34 UTC
[PR] Build: Fix minor build warning related to link tag. [iceberg]
nk1506 opened a new pull request, #9823:
URL: https://github.com/apache/iceberg/pull/9823
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Fix minor build warning related to link tag. [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #9823:
URL: https://github.com/apache/iceberg/pull/9823#discussion_r1505802195
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -201,7 +201,7 @@ TableCatalog tableCatalog() {
/**
* Closes this procedure's executor service if a new one was created with {@link
- * #executorService(int, String)}. Does not block for any remaining tasks.
+ * BaseProcedure#executorService(int, String)}. Does not block for any remaining tasks.
Review Comment:
And can you also fix for other spark versions aswell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Fix minor build warning related to link tag. [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #9823:
URL: https://github.com/apache/iceberg/pull/9823#discussion_r1506125550
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -201,7 +201,7 @@ TableCatalog tableCatalog() {
/**
* Closes this procedure's executor service if a new one was created with {@link
- * #executorService(int, String)}. Does not block for any remaining tasks.
+ * BaseProcedure#executorService(int, String)}. Does not block for any remaining tasks.
Review Comment:
I haven't compiled myself. But why it is not giving the same warnings for other javadocs in the same class, like `#withIcebergTable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Fix minor build warning related to link tag. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #9823:
URL: https://github.com/apache/iceberg/pull/9823#issuecomment-1968781650
@nk1506 do you maybe have the warning that indicated an issue with the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Fix minor build warning related to link tag. [iceberg]
Posted by "nk1506 (via GitHub)" <gi...@apache.org>.
nk1506 commented on PR #9823:
URL: https://github.com/apache/iceberg/pull/9823#issuecomment-1968778318
CC: @nastra , @ajantha-bhat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Fix minor build warning related to link tag. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #9823:
URL: https://github.com/apache/iceberg/pull/9823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org