[jira] [Commented] (CASSANDRA-10215) Reduce redundant secondary index selection lookups

["Sam Tunnicliffe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733598#comment-14733598 ] 

Sam Tunnicliffe commented on CASSANDRA-10215:
---------------------------------------------

bq. Why use a UUID vs just passing the name? 

Actually, my intention was to keep the size bounded, more than just to have it fixed. Do you think the additional debugging info is worth the potential increase in message size? It's probably only a few bytes in most cases, though I would guess that most index names are > 16 bytes.

bq. Why do you have IndexMetadata in the constructor of the read command when it's always passing Optional.empty() in the code?

It wasn't *always* passing {{Optional.empty()}}, the super call from {{PartitionRangeReadCommand}} would pass through its own argument which may not be empty. You're right though, originally the member was final but now the {{ReadCommand}} ctor doesn't need that argument, as PRRC can just set it in its own ctor. I've pushed a commit to fix that up.


> Reduce redundant secondary index selection lookups
> --------------------------------------------------
>
>                 Key: CASSANDRA-10215
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10215
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.0 rc1
>
>
> Once an index has been identified as being the one that should be used for a given query, it should be included as part of the {{ReadCommand}} so that it can be retrieved when needed during execution. Currently we don't do this, meaning that the index selection process implemented in {{SIM::getBestIndexFor}} is run multiple times on both the coordinator and each replica when performing a range command.
> This is also a pre-requisite of CASSANDRA-10214



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)