[GitHub] Mogball commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice

[gi...@git.apache.org]

Mogball commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice
URL: https://github.com/apache/incubator-superset/pull/3461#discussion_r138772934
 
 

 ##########
 File path: superset/assets/javascripts/dashboard/components/SliceCell.jsx
 ##########
 @@ -42,10 +42,20 @@ function SliceCell({ expandedSlices, removeSlice, slice }) {
               >
                 <i className="fa fa-pencil" />
               </a>
-              <a href={getExploreUrl(slice.form_data, 'csv')} title="Export CSV" data-toggle="tooltip">
+              <a
+                className="exportCSV"
+                href={getExploreUrl(slice.form_data, 'csv')}
+                title="Export CSV"
+                data-toggle="tooltip"
+              >
 
 Review comment:
   `className` was added, and eslint wants the code formatted this way when having it on one line would exceed 100 characters
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services