You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2019/05/03 16:49:53 UTC

[commons-dbcp] 02/02: Use form that ensures checked exceptions are caught.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit 2ee3c53e75e9ad899ed2aa06bfd882ebeea7b4a2
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri May 3 17:49:03 2019 +0100

    Use form that ensures checked exceptions are caught.
---
 .../java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
index b852358..9e312ce 100644
--- a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
@@ -190,7 +190,7 @@ public class BasicManagedDataSource extends BasicDataSource {
             }
 
             try {
-                xaDataSourceInstance = (XADataSource) xaDataSourceClass.newInstance();
+                xaDataSourceInstance = (XADataSource) xaDataSourceClass.getConstructor().newInstance();
             } catch (final Exception t) {
                 final String message = "Cannot create XA data source of class '" + xaDataSource + "'";
                 throw new SQLException(message, t);


Re: [commons-dbcp] 02/02: Use form that ensures checked exceptions are caught.

Posted by Gary Gregory <ga...@gmail.com>.
Mark,

Would you please create a jira and changes.xml entry so our users know
about this fix?

Thank you,
Gary

On Fri, May 3, 2019, 12:49 <ma...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
>
> commit 2ee3c53e75e9ad899ed2aa06bfd882ebeea7b4a2
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Fri May 3 17:49:03 2019 +0100
>
>     Use form that ensures checked exceptions are caught.
> ---
>  .../java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java   |
> 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
> b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
> index b852358..9e312ce 100644
> ---
> a/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
> +++
> b/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java
> @@ -190,7 +190,7 @@ public class BasicManagedDataSource extends
> BasicDataSource {
>              }
>
>              try {
> -                xaDataSourceInstance = (XADataSource)
> xaDataSourceClass.newInstance();
> +                xaDataSourceInstance = (XADataSource)
> xaDataSourceClass.getConstructor().newInstance();
>              } catch (final Exception t) {
>                  final String message = "Cannot create XA data source of
> class '" + xaDataSource + "'";
>                  throw new SQLException(message, t);
>
>