You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2026/01/29 00:43:58 UTC
[PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
englefly opened a new pull request, #60324:
URL: https://github.com/apache/doris/pull/60324
### What problem does this PR solve?
delete table should satisfy:
olapTable.getKeysType() == KeysType.UNIQUE_KEYS && olapTable.getEnableUniqueKeyMergeOnWrite()
&& !olapTable.getEnableMowLightDelete()
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow closed pull request #60324: [fix](delete) DeleteFromUsingCommand should check table property
URL: https://github.com/apache/doris/pull/60324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60324:
URL: https://github.com/apache/doris/pull/60324#issuecomment-3814808020
<details>
<summary>TPC-H: <b>Total hot run time: 31772 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 125390b5e8db3fc50c3230b02fd93a5235579f03, data reload: false
------ Round 1 ----------------------------------
q1 17604 5233 5083 5083
q2 2020 330 206 206
q3 10204 1304 741 741
q4 10214 884 318 318
q5 7542 2117 1919 1919
q6 198 186 155 155
q7 861 741 596 596
q8 9255 1349 1130 1130
q9 5173 4799 4891 4799
q10 6835 1943 1566 1566
q11 510 306 264 264
q12 330 371 224 224
q13 17781 4052 3219 3219
q14 239 239 224 224
q15 905 844 807 807
q16 658 692 627 627
q17 625 805 521 521
q18 6863 6464 6355 6355
q19 1236 981 617 617
q20 382 345 234 234
q21 2666 1923 1887 1887
q22 357 320 280 280
Total cold run time: 102458 ms
Total hot run time: 31772 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5328 5287 5323 5287
q2 260 339 254 254
q3 2173 2690 2285 2285
q4 1347 1729 1328 1328
q5 4325 4188 4282 4188
q6 216 176 141 141
q7 2098 2110 1785 1785
q8 2624 2413 2421 2413
q9 7699 7633 7540 7540
q10 2948 3165 2769 2769
q11 574 500 457 457
q12 676 747 637 637
q13 3832 4376 3679 3679
q14 285 305 285 285
q15 886 822 863 822
q16 679 765 695 695
q17 1134 1390 1321 1321
q18 8424 7893 8038 7893
q19 885 956 886 886
q20 2160 2225 2103 2103
q21 5005 4344 4189 4189
q22 574 541 531 531
Total cold run time: 54132 ms
Total hot run time: 51488 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60324:
URL: https://github.com/apache/doris/pull/60324#issuecomment-3814693956
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60324:
URL: https://github.com/apache/doris/pull/60324#issuecomment-3814860143
<details>
<summary>ClickBench: <b>Total hot run time: 28.36 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 125390b5e8db3fc50c3230b02fd93a5235579f03, data reload: false
query1 0.05 0.05 0.06
query2 0.09 0.04 0.04
query3 0.26 0.09 0.09
query4 1.60 0.11 0.11
query5 0.28 0.25 0.26
query6 1.17 0.68 0.66
query7 0.04 0.03 0.03
query8 0.06 0.04 0.04
query9 0.57 0.50 0.50
query10 0.55 0.54 0.55
query11 0.15 0.10 0.10
query12 0.14 0.10 0.10
query13 0.64 0.62 0.62
query14 1.07 1.07 1.06
query15 0.88 0.86 0.87
query16 0.42 0.37 0.42
query17 1.17 1.12 1.10
query18 0.22 0.21 0.21
query19 2.01 1.91 2.02
query20 0.02 0.01 0.01
query21 15.45 0.25 0.15
query22 5.24 0.06 0.05
query23 16.00 0.30 0.10
query24 1.35 0.33 0.58
query25 0.12 0.07 0.05
query26 0.15 0.13 0.14
query27 0.11 0.06 0.05
query28 4.41 1.15 0.96
query29 12.55 3.90 3.20
query30 0.28 0.14 0.11
query31 2.83 0.63 0.42
query32 3.23 0.59 0.50
query33 3.26 3.26 3.23
query34 16.59 5.39 4.72
query35 4.79 4.85 4.82
query36 0.65 0.49 0.50
query37 0.12 0.07 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.20 0.16 0.16
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 99.01 s
Total hot run time: 28.36 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60324:
URL: https://github.com/apache/doris/pull/60324#issuecomment-3815402777
# FE Regression Coverage Report
Increment line coverage ` 69.57% (16/23)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60324_125390b5e8db3fc50c3230b02fd93a5235579f03_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60324_125390b5e8db3fc50c3230b02fd93a5235579f03_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](delete) DeleteFromUsingCommand should check table property [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60324:
URL: https://github.com/apache/doris/pull/60324#issuecomment-3814693649
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org