You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/13 08:04:26 UTC

[GitHub] [skywalking] wu-sheng opened a new issue, #8864: [Bug] [Event] Can't split service ID into 2 parts

wu-sheng opened a new issue, #8864:
URL: https://github.com/apache/skywalking/issues/8864

### Search before asking

- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.

### Apache SkyWalking Component

OAP server (apache/skywalking)

### What happened

### What you expected to happen

Event metrics could cause this error.

### How to reproduce

`oal/event.oal` could make this happens

### Anything else

The event now is treated as a manual metric source(like an updatable record) and a source of OAL dispatcher.

But in the process, it doesn't declare entity ID, so when it is forwarded into alarm kernel, this `Can't split service ID into 2 parts` raises up.
Meanwhile, I am not sure why the timebucket could not be downsampling in OAL-generated metrics. The only thing I could guess is, somehow, it could be not-set.

The `Can't split service ID into 2 parts` is easy to fix. `@ScopeDefaultColumn.VirtualColumnDefinition(fieldName = "entityId", columnName = "entity_id", isID = true, type = String.class)` should be added into event.

@kezhenxu94 Also, we should consider seriously, whether this is a good practice to use one object being both source and manual metrics. Many methods in here could confuse developers and readers, they are responsible to persistent of metrics, but actually, more other metrics are generated through OAL engine in the runtime.

### Are you willing to submit PR?

- [ ] Yes I am willing to submit a PR!

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #8864: [Bug] [Event] Can't split service ID into 2 parts

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #8864: [Bug] [Event] Can't split service ID into 2 parts
URL: https://github.com/apache/skywalking/issues/8864


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org