[jira] Closed: (DERBY-1571) NetworkServerControlImpl.consoleExceptionPrintTrace() prints stack trace even when logWriter is null

["Knut Anders Hatlen (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-1571?page=all ]

Knut Anders Hatlen closed DERBY-1571.
-------------------------------------

    Fix Version/s: 10.2.0.0
       Resolution: Fixed
       Derby Info:   (was: [Patch Available])

Thanks for looking at the patch, Fernanda! Committed revision 425703.

> NetworkServerControlImpl.consoleExceptionPrintTrace() prints stack trace even when logWriter is null
> ----------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1571
>                 URL: http://issues.apache.org/jira/browse/DERBY-1571
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server, Newcomer, Regression Test Failure
>    Affects Versions: 10.2.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.2.0.0
>
>         Attachments: 1571-v2.diff, 1571.diff
>
>
> NetworkServerControlImpl.consoleExceptionPrintTrace() prints the stack
> trace to System.err if logWriter is null. This has occasionally caused
> errors in the regression tests. See
> http://www.multinet.no/~solberg/public/Apache/10.2.0.3_Snapshot/jvm1.5/testlog/sparc_zone3/412239-derbyall_diff.txt
> for an example.
> The test failure happens when NetworkServerControlImpl.shutdown() has
> sent the shutdown command and starts a loop calling ping() until it
> gets an error. Since it expects ping() to fail, it sets logWriter to
> null to avoid getting error messages printed on the console.
> In most cases, the network server is already stopped before the first
> call to ping(). Then ping() fails when calling setUpSocket(), and no
> message is printed. On the other hand, if the server is stopped while
> ping() is being executed, the error might occur other places. For
> instance, it might fail with a SocketException in
> fillReplyBuffer(). fillReplyBuffer() then calls clientSocketError(),
> which in turn calls consolePropertyMessage() and
> consoleExceptionPrintTrace().  consolePropertyMessage() correctly
> suppresses the error message, but consoleExceptionPrintTrace() prints
> the stack trace.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira