You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/03/25 18:44:01 UTC

[GitHub] [superset] john-bodley commented on a diff in pull request #23481: chore: Adds a tooltip to pre-filter in native filters modal

john-bodley commented on code in PR #23481:
URL: https://github.com/apache/superset/pull/23481#discussion_r1148415401


##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -85,6 +85,7 @@ export const nativeFilterTooltips = {
   multipleSelect: 'Allow selecting multiple values',
   defaultValue:
     'Default value must be set when "Filter value is required" is checked',
+  preFilter: `Limits the number of selectable values in a filter. This is useful when you want to display a subset of the column's values either for performance reasons or business rules. Some examples include limiting the number of people displayed to a particular business unit or showing only people registered in the last 90 days.`,

Review Comment:
   @michael-s-molina if it's ok with you I might tweak the copy of the this tooltip, i.e., make it more concise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org