You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/19 09:58:02 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30732: Add explicit information about how to write task logs
potiuk opened a new pull request, #30732:
URL: https://github.com/apache/airflow/pull/30732
There was no explicit information in our documentation on how to write logs from your tasks. While for classic operators, that is easy and straightforward as they all have log property which is the right logger coming from LoggingMixin, for taskflow code and custom classes it is is not straightforward that you have to use `airflow.task` logger (or a child of it) or that you have extend LoggingMixin to use the built-in logging configuration.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30732: Add explicit information about how to write task logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30732:
URL: https://github.com/apache/airflow/pull/30732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30732: Add explicit information about how to write task logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30732:
URL: https://github.com/apache/airflow/pull/30732#issuecomment-1514460257
Even as a maintainer I am not sure if I provided the right advice to be honest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30732: Add explicit information about how to write task logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30732:
URL: https://github.com/apache/airflow/pull/30732#issuecomment-1514460449
But I hope so :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #30732: Add explicit information about how to write task logs
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #30732:
URL: https://github.com/apache/airflow/pull/30732#issuecomment-1514925613
> Even as a maintainer I am not sure if I provided the right advice to be honest.
i'll take a look, since i got my hands dirty with this recently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30732: Add explicit information about how to write task logs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30732:
URL: https://github.com/apache/airflow/pull/30732#issuecomment-1514932512
Yeah. We can alwasy update it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org