You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/05/11 02:25:34 UTC
[kudu-CR] hms: ignore DROP TABLE events from external tables
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13315
Change subject: hms: ignore DROP TABLE events from external tables
......................................................................
hms: ignore DROP TABLE events from external tables
To maintain the expectation that dropping an external table will not
delete the underlying data of a Kudu table, this patch updates the
HMS notification log listener to ignore external tables.
To maintain the behavior that Kudu tables that are synchronized with the
HMS can continue to be dropped, this patch also sets the default table
type to be managed.
This change makes it difficult to delete the underlying Kudu table of an
external table. A follow-up patch will provide the semantics described
in the new disabled test TestDropExternalTableThroughKudu.
Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
---
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/hms_notification_log_listener.cc
4 files changed, 81 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13315/1
--
To view, visit http://gerrit.cloudera.org:8080/13315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
Gerrit-Change-Number: 13315
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] WIP hms: ignore DROP TABLE events from external tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13315 )
Change subject: WIP hms: ignore DROP TABLE events from external tables
......................................................................
Patch Set 2: Code-Review+1
Code looks fine but yeah, tests aren't too happy.
--
To view, visit http://gerrit.cloudera.org:8080/13315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
Gerrit-Change-Number: 13315
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 11 May 2019 21:12:14 +0000
Gerrit-HasComments: No
[kudu-CR] WIP hms: ignore DROP TABLE events from external tables
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13315
to look at the new patch set (#2).
Change subject: WIP hms: ignore DROP TABLE events from external tables
......................................................................
WIP hms: ignore DROP TABLE events from external tables
To maintain the expectation that dropping an external table will not
delete the underlying data of a Kudu table, this patch updates the
HMS notification log listener to ignore external tables.
To maintain the behavior that Kudu tables that are synchronized with the
HMS can continue to be dropped, this patch also sets the default table
type to be managed.
WIP: I looped master-stress-test with 7 stress threads and with this
patch, it failed 34/500 times.
This change makes it difficult to delete the underlying Kudu table of an
external table. A follow-up patch will provide the semantics described
in the new disabled test TestDropExternalTableThroughKudu.
Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
---
M src/kudu/hms/hms_catalog.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
7 files changed, 86 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13315/2
--
To view, visit http://gerrit.cloudera.org:8080/13315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
Gerrit-Change-Number: 13315
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] WIP hms: ignore DROP TABLE events from external tables
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13315 )
Change subject: WIP hms: ignore DROP TABLE events from external tables
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13315/1/src/kudu/integration-tests/master_hms-itest.cc
File src/kudu/integration-tests/master_hms-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13315/1/src/kudu/integration-tests/master_hms-itest.cc@49
PS1, Line 49: using kudu::hms::HmsCatalog;
> warning: using decl 'HmsCatalog' is unused [misc-unused-using-decls]
Done
--
To view, visit http://gerrit.cloudera.org:8080/13315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
Gerrit-Change-Number: 13315
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 11 May 2019 07:09:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP hms: ignore DROP TABLE events from external tables
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/13315 )
Change subject: WIP hms: ignore DROP TABLE events from external tables
......................................................................
Abandoned
Grant took care of this in a separate patch.
--
To view, visit http://gerrit.cloudera.org:8080/13315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9b593ac40022d881569c524ac8f3c23b6f8815dc
Gerrit-Change-Number: 13315
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)