You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/05/03 12:50:37 UTC
[GitHub] [wicket] martin-g commented on a diff in pull request #522: Cut back slightly on some String instance creation in PageInfo and friends.
martin-g commented on code in PR #522:
URL: https://github.com/apache/wicket/pull/522#discussion_r863737201
##########
wicket-request/src/main/java/org/apache/wicket/request/mapper/info/PageComponentInfo.java:
##########
@@ -69,23 +69,18 @@ public ComponentInfo getComponentInfo()
@Override
public String toString()
{
- StringBuilder result = new StringBuilder();
- if (pageInfo != null)
- {
- result.append(pageInfo.toString());
- }
+ String result = pageInfo.toString();
if (componentInfo != null)
{
- result.append(SEPARATOR);
- result.append(componentInfo);
+ result = result + SEPARATOR + componentInfo;
Review Comment:
The check `if (pageInfo != null)` is no more there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org