[GitHub] marcoabreu commented on issue #9330: Add clang job to the CI

[GitBox <gi...@apache.org>]

marcoabreu commented on issue #9330: Add clang job to the CI
URL: https://github.com/apache/incubator-mxnet/pull/9330#issuecomment-356446109
 
 
   Do you see any downside to having OPENMP enabled at this point so we don't
   have to run two jobs?
   
   On Tue, Jan 9, 2018 at 9:32 PM, Kellen Sunderland <no...@github.com>
   wrote:
   
   > *@KellenSunderland* commented on this pull request.
   > ------------------------------
   >
   > In Jenkinsfile
   > <https://github.com/apache/incubator-mxnet/pull/9330#discussion_r160516953>
   > :
   >
   > > @@ -168,6 +168,24 @@ try {
   >          }
   >        }
   >      },
   > +    'CPU: Clang': {
   > +      node('mxnetlinux-cpu') {
   > +        ws('workspace/build-cpu-clang') {
   > +          init_git()
   > +          def flag = """ \
   > +            USE_PROFILER=1                \
   > +            USE_CPP_PACKAGE=1             \
   > +            USE_BLAS=openblas             \
   > +            USE_OPENMP=0                  \
   >
   > Yes, correct about disabling USE_OPENMP. The goal of this job is to
   > protect against accidental broken builds on OSX by using a similar build
   > chain and flags on linux.
   >
   > I think you do have a good point though, I can pretty easily create
   > another job with a modern clang that has USE_OPENMP turned on. IMO the
   > extra environment would be valuable to test, and shouldn't use too many
   > resources relative to other CI jobs.
   >
   > ?
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-mxnet/pull/9330#discussion_r160516953>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ARxB69V0xuZfPrkFUji81eJahH5OF0qNks5tI8zegaJpZM4RVZfj>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services