You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "eric9204 (via GitHub)" <gi...@apache.org> on 2023/05/26 06:38:38 UTC

[GitHub] [hudi] eric9204 opened a new pull request, #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

eric9204 opened a new pull request, #8815:
URL: https://github.com/apache/hudi/pull/8815

   …which like --props and --hoodie-conf.
   
   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   add options like `--props` and `--hoodie-conf`, make HoodieFlinkCompactor can get more configs.
   
   ### Impact
   
   no
   
   ### Risk level (write none, low medium or high below)
   
   no
   
   ### Documentation Update
   
   `--hoodie-conf ` and `--props` in `FlinkCompactionConfig`
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] eric9204 commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "eric9204 (via GitHub)" <gi...@apache.org>.
eric9204 commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1564122383

   
   
   
   
   > @eric9204, could you please also doing this change in `HoodieFlinkClusteringJob`?
   
   @SteNicholas Thank you for your reply, I've checked, these changes already exists in both `HoodieFlinkClusteringJob` and `HoodieFlinkStreamer`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1563931495

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1fbdf8b4dfc319c87e106de6e065b86a70a13f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8815:
URL: https://github.com/apache/hudi/pull/8815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1566418216

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17457",
       "triggerID" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1fbdf8b4dfc319c87e106de6e065b86a70a13f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393) 
   * 770dfcdb51176885ef889ddad0bcdea9fdc50dcc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] SteNicholas commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1564087888

   @eric9204, could you please also doing this change in `HoodieFlinkClusteringJob`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] eric9204 commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "eric9204 (via GitHub)" <gi...@apache.org>.
eric9204 commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1565211717

   > @eric9204 Can you check the test failures?
   
   @danny0405 It seems that the test failure was caused by check style, and I will fix it soon. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1564387826

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1fbdf8b4dfc319c87e106de6e065b86a70a13f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1566413706

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1fbdf8b4dfc319c87e106de6e065b86a70a13f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393) 
   * 770dfcdb51176885ef889ddad0bcdea9fdc50dcc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1565168363

   @eric9204 Can you check the test failures?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1563943788

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1fbdf8b4dfc319c87e106de6e065b86a70a13f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8815: [HUDI-6268]Make HoodieFlinkCompactor could read parameter by specifying options …

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8815:
URL: https://github.com/apache/hudi/pull/8815#issuecomment-1566629198

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17393",
       "triggerID" : "aa1fbdf8b4dfc319c87e106de6e065b86a70a13f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17457",
       "triggerID" : "770dfcdb51176885ef889ddad0bcdea9fdc50dcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 770dfcdb51176885ef889ddad0bcdea9fdc50dcc Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org