[jira] [Commented] (THRIFT-2489) Peer host name not provied when performing AccessManager common name verification.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975586#comment-13975586 ] 

ASF GitHub Bot commented on THRIFT-2489:
----------------------------------------

GitHub user chris5287 opened a pull request:

    https://github.com/apache/thrift/pull/102

    [THRIFT-2489] Pull Request

    Peer host name not provied when performing AccessManager common name verification.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chris5287/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #102
    
----
commit fd2afa58bff579c2a03281a34afda990e2f499e3
Author: Chris Stylianou <ch...@gmail.com>
Date:   2014-04-21T14:06:20Z

    [THRIFT-2489] Pull Request
    
    Peer host name not provied when performing AccessManager common name verification.

----


> Peer host name not provied when performing AccessManager common name verification.
> ----------------------------------------------------------------------------------
>
>                 Key: THRIFT-2489
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2489
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.1
>            Reporter: Chris Stylianou
>              Labels: c++, ssl, thrift
>
> When a server tries to use the AccessManager to verify the host name of a client against a certificate common name, TSSLSocket.cpp can call getHost() instead of getPeerHost(), which is incorrect behaviour.



--
This message was sent by Atlassian JIRA
(v6.2#6252)