[jira] [Commented] (THRIFT-2738) JS coding standards

["Andrew de Andrade (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305484#comment-14305484 ] 

Andrew de Andrade commented on THRIFT-2738:
-------------------------------------------

Randy,

After all my other patches are in (because enforcing and updating the coding standards are going to change a LOT of lines of code and render all those patches stale), I'm going to add an .editorconfig file to lib/nodejs and add the lint-trap module to the devDependencies. lint-trap is a zero-config linter that has rules that raynos (one of the top contributors in the nodejs ecosystem) and I came up with. It enforces a lot of best practices and is designed for minimizing personal style (which is good for codebases with many contributors). Alternatively, I can just pull out the .eslintrc and .jscsrc files from lint-trap and commit them to thrift and use eslint and jscs instead.



> JS coding standards
> -------------------
>
>                 Key: THRIFT-2738
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2738
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library, Node.js - Library
>            Reporter: Konrad Grochowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)