You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/08 11:48:44 UTC
[GitHub] [skywalking] Ax1an opened a new pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Ax1an opened a new pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516
#6498
I find that telemetry data about log in metrics have been added. So I added telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `3.04%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 57.06% +3.04%
+ Complexity 4080 4004 -76
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 13954 -6461
+ Misses 16397 9300 -7097
- Partials 982 1200 +218
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1240 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `0.88%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 51.25% -0.89%
+ Complexity 3764 3680 -84
============================================
Files 1006 991 -15
Lines 24671 24331 -340
Branches 2403 2359 -44
============================================
- Hits 12863 12471 -392
- Misses 10712 10778 +66
+ Partials 1096 1082 -14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `3.09%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.06% -3.10%
+ Complexity 4094 2979 -1115
============================================
Files 1779 836 -943
Lines 37794 20680 -17114
Branches 4156 1953 -2203
============================================
- Hits 20469 10561 -9908
+ Misses 16343 9280 -7063
+ Partials 982 839 -143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `4.38%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 49.14% 53.52% +4.38%
- Complexity 3623 4038 +415
============================================
Files 1001 1779 +778
Lines 24662 37840 +13178
Branches 2395 4161 +1766
============================================
+ Hits 12119 20253 +8134
- Misses 11522 16604 +5082
+ Partials 1021 983 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.17%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.02% +18.17%
- Complexity 2208 3516 +1308
=============================================
Files 971 987 +16
Lines 23644 24235 +591
Branches 2297 2353 +56
=============================================
+ Hits 7296 11882 +4586
+ Misses 15791 11351 -4440
- Partials 557 1002 +445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [374 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.46% +1.30%
+ Complexity 4094 3927 -167
============================================
Files 1779 988 -791
Lines 37794 24475 -13319
Branches 4156 2370 -1786
============================================
- Hits 20469 13574 -6895
+ Misses 16343 9719 -6624
- Partials 982 1182 +200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.33%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.82% -2.34%
+ Complexity 4094 3007 -1087
============================================
Files 1779 836 -943
Lines 37794 20690 -17104
Branches 4156 1954 -2202
============================================
- Hits 20469 10723 -9746
+ Misses 16343 9112 -7231
+ Partials 982 855 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `21.14%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 32.87% -21.15%
+ Complexity 4080 1977 -2103
=============================================
Files 1779 805 -974
Lines 37794 19574 -18220
Branches 4156 1829 -2327
=============================================
- Hits 20415 6434 -13981
+ Misses 16397 12671 -3726
+ Partials 982 469 -513
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1454 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `22.34%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 53.20% +22.34%
- Complexity 2208 4005 +1797
=============================================
Files 971 1779 +808
Lines 23644 37840 +14196
Branches 2297 4161 +1864
=============================================
+ Hits 7296 20133 +12837
- Misses 15791 16732 +941
- Partials 557 975 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1399 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `0.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.94% 54.03% +0.08%
+ Complexity 4094 4088 -6
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
+ Hits 20423 20447 +24
+ Misses 16453 16412 -41
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <0.00%> (-2.13%)` | `14.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `97.24% <0.00%> (-1.84%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.13%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 33.55% 52.68% +19.13%
- Complexity 2448 3715 +1267
=============================================
Files 1001 988 -13
Lines 24517 24294 -223
Branches 2382 2358 -24
=============================================
+ Hits 8227 12800 +4573
+ Misses 15664 10414 -5250
- Partials 626 1080 +454
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.20%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.94% -8.21%
+ Complexity 4094 3267 -827
============================================
Files 1779 958 -821
Lines 37794 23541 -14253
Branches 4156 2285 -1871
============================================
- Hits 20469 10817 -9652
+ Misses 16343 11790 -4553
+ Partials 982 934 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1332 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.14%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.00% +18.14%
- Complexity 2208 3516 +1308
=============================================
Files 971 987 +16
Lines 23644 24234 +590
Branches 2297 2349 +52
=============================================
+ Hits 7296 11876 +4580
+ Misses 15791 11356 -4435
- Partials 557 1002 +445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.48%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.64% +0.48%
+ Complexity 4094 3884 -210
============================================
Files 1779 988 -791
Lines 37794 24462 -13332
Branches 4156 2370 -1786
============================================
- Hits 20469 13368 -7101
+ Misses 16343 9941 -6402
- Partials 982 1153 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `0.92%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 53.09% -0.93%
+ Complexity 4080 3774 -306
============================================
Files 1779 988 -791
Lines 37794 24309 -13485
Branches 4156 2360 -1796
============================================
- Hits 20415 12907 -7508
+ Misses 16397 10300 -6097
- Partials 982 1102 +120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1269 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `3.47%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 48.65% -3.48%
+ Complexity 3764 3577 -187
============================================
Files 1006 987 -19
Lines 24671 24349 -322
Branches 2403 2363 -40
============================================
- Hits 12863 11848 -1015
- Misses 10712 11482 +770
+ Partials 1096 1019 -77
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `24.82%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 55.67% +24.82%
- Complexity 2208 3954 +1746
=============================================
Files 971 988 +17
Lines 23644 24446 +802
Branches 2297 2373 +76
=============================================
+ Hits 7296 13611 +6315
+ Misses 15791 9641 -6150
- Partials 557 1194 +637
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [412 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `5.26%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 48.89% -5.27%
+ Complexity 4094 3521 -573
============================================
Files 1779 987 -792
Lines 37794 24196 -13598
Branches 4156 2349 -1807
============================================
- Hits 20469 11831 -8638
+ Misses 16343 11356 -4987
- Partials 982 1009 +27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1306 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `7.15%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 46.84% -7.16%
+ Complexity 4079 2694 -1385
============================================
Files 1779 1769 -10
Lines 37794 37398 -396
Branches 4157 4306 +149
============================================
- Hits 20408 17520 -2888
- Misses 16403 18926 +2523
+ Partials 983 952 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.01% <0.00%> (-0.51%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <100.00%> (-11.18%)` | `0.00 <0.00> (-11.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [271 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `27.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 58.56% +27.70%
+ Complexity 2208 825 -1383
=============================================
Files 971 172 -799
Lines 23644 4202 -19442
Branches 2297 482 -1815
=============================================
- Hits 7296 2461 -4835
+ Misses 15791 1432 -14359
+ Partials 557 309 -248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...plugin/elasticsearch/query/MetadataQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0YWRhdGFRdWVyeUVzREFPLmphdmE=) | | | |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | | | |
| [...tion/apollo/ApolloConfigurationCenterSettings.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ3VyYXRpb25DZW50ZXJTZXR0aW5ncy5qYXZh) | | | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | | | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | | | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | | | |
| [...p/server/tool/profile/exporter/ExporterConfig.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3QtYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdG9vbC9wcm9maWxlL2V4cG9ydGVyL0V4cG9ydGVyQ29uZmlnLmphdmE=) | | | |
| ... and [941 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.40%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.56% +0.40%
+ Complexity 4094 3868 -226
============================================
Files 1779 987 -792
Lines 37794 24418 -13376
Branches 4156 2370 -1786
============================================
- Hits 20469 13324 -7145
+ Misses 16343 9955 -6388
- Partials 982 1139 +157
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `20.87%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.72% +20.87%
- Complexity 2208 3649 +1441
=============================================
Files 971 987 +16
Lines 23644 24249 +605
Branches 2297 2354 +57
=============================================
+ Hits 7296 12544 +5248
+ Misses 15791 10647 -5144
- Partials 557 1058 +501
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `11.04%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 41.90% +11.04%
- Complexity 2208 3016 +808
=============================================
Files 971 958 -13
Lines 23644 23479 -165
Branches 2297 2277 -20
=============================================
+ Hits 7296 9838 +2542
+ Misses 15791 12798 -2993
- Partials 557 843 +286
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `1.17%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 52.84% -1.18%
+ Complexity 4080 3756 -324
============================================
Files 1779 988 -791
Lines 37794 24309 -13485
Branches 4156 2360 -1796
============================================
- Hits 20415 12845 -7570
+ Misses 16397 10361 -6036
- Partials 982 1103 +121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **decrease** coverage by `0.41%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.93% 53.52% -0.42%
+ Complexity 4093 4038 -55
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
- Hits 20418 20253 -165
- Misses 16456 16604 +148
- Partials 982 983 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-68.34%)` | `0.00% <0.00%> (-12.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.43%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 33.55% 52.98% +19.43%
- Complexity 2448 3729 +1281
=============================================
Files 1001 988 -13
Lines 24517 24294 -223
Branches 2382 2358 -24
=============================================
+ Hits 8227 12873 +4646
+ Misses 15664 10330 -5334
- Partials 626 1091 +465
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.27% <0.00%> (-52.46%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [329 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `24.77%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 55.63% +24.77%
- Complexity 2208 3953 +1745
=============================================
Files 971 988 +17
Lines 23644 24446 +802
Branches 2297 2373 +76
=============================================
+ Hits 7296 13601 +6305
+ Misses 15791 9652 -6139
- Partials 557 1193 +636
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [412 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.66%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.49% -1.67%
+ Complexity 4094 3732 -362
============================================
Files 1779 988 -791
Lines 37794 24444 -13350
Branches 4156 2369 -1787
============================================
- Hits 20469 12832 -7637
+ Misses 16343 10539 -5804
- Partials 982 1073 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `6.59%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 37.44% +6.59%
- Complexity 2208 2719 +511
============================================
Files 971 956 -15
Lines 23644 23143 -501
Branches 2297 2230 -67
============================================
+ Hits 7296 8667 +1371
+ Misses 15791 13744 -2047
- Partials 557 732 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [249 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `17.49%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 36.66% -17.50%
+ Complexity 4094 2160 -1934
=============================================
Files 1779 806 -973
Lines 37794 19726 -18068
Branches 4156 1862 -2294
=============================================
- Hits 20469 7232 -13237
+ Misses 16343 11945 -4398
+ Partials 982 549 -433
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `1.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 53.44% +1.30%
- Complexity 3764 3843 +79
============================================
Files 1006 987 -19
Lines 24671 24391 -280
Branches 2403 2368 -35
============================================
+ Hits 12863 13036 +173
+ Misses 10712 10218 -494
- Partials 1096 1137 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.39%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.41% +4.39%
+ Complexity 4080 4079 -1
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14297 -6118
+ Misses 16397 8929 -7468
- Partials 982 1250 +268
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `4.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.73% +4.57%
+ Complexity 4094 829 -3265
============================================
Files 1779 172 -1607
Lines 37794 4202 -33592
Branches 4156 482 -3674
============================================
- Hits 20469 2468 -18001
+ Misses 16343 1420 -14923
+ Partials 982 314 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `20.63% <0.00%> (-43.43%)` | `6.00% <0.00%> (ø%)` | |
| ... and [1692 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `4.02%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.18% +4.02%
+ Complexity 4094 4068 -26
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14241 -6228
+ Misses 16343 8986 -7357
- Partials 982 1249 +267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1242 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `2.92%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 56.94% +2.92%
+ Complexity 4080 4001 -79
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 13925 -6490
+ Misses 16397 9339 -7058
- Partials 982 1190 +208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1240 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `2.37%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 49.76% -2.38%
+ Complexity 3764 3603 -161
============================================
Files 1006 991 -15
Lines 24671 24331 -340
Branches 2403 2359 -44
============================================
- Hits 12863 12108 -755
- Misses 10712 11162 +450
+ Partials 1096 1061 -35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [189 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `5.76%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 48.38% -5.77%
+ Complexity 4094 2891 -1203
============================================
Files 1779 836 -943
Lines 37794 20680 -17114
Branches 4156 1953 -2203
============================================
- Hits 20469 10007 -10462
+ Misses 16343 9877 -6466
+ Partials 982 796 -186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.51%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.64% -2.52%
+ Complexity 4094 3701 -393
============================================
Files 1779 988 -791
Lines 37794 24444 -13350
Branches 4156 2369 -1787
============================================
- Hits 20469 12623 -7846
+ Misses 16343 10772 -5571
- Partials 982 1049 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `17.10%`.
> The diff coverage is `62.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 37.05% -17.11%
+ Complexity 4094 2711 -1383
=============================================
Files 1779 957 -822
Lines 37794 23428 -14366
Branches 4156 2271 -1885
=============================================
- Hits 20469 8682 -11787
+ Misses 16343 13966 -2377
+ Partials 982 780 -202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1400 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `0.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.94% 54.03% +0.08%
+ Complexity 4094 4088 -6
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
+ Hits 20423 20447 +24
+ Misses 16453 16412 -41
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <0.00%> (-2.13%)` | `14.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `97.24% <0.00%> (-1.84%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `7.98%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 46.02% -7.99%
+ Complexity 4080 2772 -1308
============================================
Files 1779 836 -943
Lines 37794 20616 -17178
Branches 4156 1948 -2208
============================================
- Hits 20415 9489 -10926
+ Misses 16397 10382 -6015
+ Partials 982 745 -237
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.46%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 36.81% 55.28% +18.46%
- Complexity 2653 3880 +1227
=============================================
Files 1001 988 -13
Lines 24524 24322 -202
Branches 2382 2360 -22
=============================================
+ Hits 9029 13446 +4417
+ Misses 14804 9702 -5102
- Partials 691 1174 +483
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.01%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.17% +1.01%
+ Complexity 4094 3918 -176
============================================
Files 1779 988 -791
Lines 37794 24475 -13319
Branches 4156 2370 -1786
============================================
- Hits 20469 13505 -6964
+ Misses 16343 9806 -6537
- Partials 982 1164 +182
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `10.84%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 43.31% -10.85%
+ Complexity 4094 3106 -988
=============================================
Files 1779 958 -821
Lines 37794 23511 -14283
Branches 4156 2282 -1874
=============================================
- Hits 20469 10184 -10285
+ Misses 16343 12469 -3874
+ Partials 982 858 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `9.65%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 40.51% +9.65%
- Complexity 2208 2918 +710
============================================
Files 971 958 -13
Lines 23644 23366 -278
Branches 2297 2269 -28
============================================
+ Hits 7296 9466 +2170
+ Misses 15791 13085 -2706
- Partials 557 815 +258
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.87%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 56.03% +1.87%
+ Complexity 4094 3921 -173
============================================
Files 1779 988 -791
Lines 37794 24344 -13450
Branches 4156 2361 -1795
============================================
- Hits 20469 13640 -6829
+ Misses 16343 9507 -6836
- Partials 982 1197 +215
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.84%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.31% -1.85%
+ Complexity 4094 3026 -1068
============================================
Files 1779 836 -943
Lines 37794 20690 -17104
Branches 4156 1954 -2202
============================================
- Hits 20469 10824 -9645
+ Misses 16343 9001 -7342
+ Partials 982 865 -117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `3.53%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 57.55% +3.53%
+ Complexity 4080 4027 -53
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 14074 -6341
+ Misses 16397 9173 -7224
- Partials 982 1207 +225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `4.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.24% +4.08%
+ Complexity 4094 4070 -24
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14255 -6214
+ Misses 16343 8972 -7371
- Partials 982 1249 +267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1241 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792754306
@wu-sheng I probably know what the problem is and I'll try to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `2.37%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 56.39% +2.37%
+ Complexity 4080 3979 -101
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 13791 -6624
+ Misses 16397 9476 -6921
- Partials 982 1187 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `0.24%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 51.89% -0.25%
+ Complexity 3764 3747 -17
============================================
Files 1006 987 -19
Lines 24671 24369 -302
Branches 2403 2367 -36
============================================
- Hits 12863 12646 -217
+ Misses 10712 10632 -80
+ Partials 1096 1091 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.67%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.53% +18.67%
- Complexity 2208 3631 +1423
=============================================
Files 971 988 +17
Lines 23644 24414 +770
Branches 2297 2372 +75
=============================================
+ Hits 7296 12094 +4798
+ Misses 15791 11254 -4537
- Partials 557 1066 +509
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.09%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 46.95% +16.09%
- Complexity 2208 3447 +1239
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11454 +4158
+ Misses 15791 11952 -3839
- Partials 557 989 +432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `21.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.94% +21.08%
- Complexity 2208 3666 +1458
=============================================
Files 971 988 +17
Lines 23644 24294 +650
Branches 2297 2358 +61
=============================================
+ Hits 7296 12620 +5324
+ Misses 15791 10606 -5185
- Partials 557 1068 +511
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `24.30%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 29.85% -24.31%
+ Complexity 4094 2201 -1893
=============================================
Files 1779 956 -823
Lines 37794 22985 -14809
Branches 4156 2189 -1967
=============================================
- Hits 20469 6863 -13606
+ Misses 16343 15523 -820
+ Partials 982 599 -383
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1437 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `21.01%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.86% +21.01%
- Complexity 2208 3761 +1553
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12665 +5369
+ Misses 15791 10648 -5143
- Partials 557 1104 +547
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.43%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.72% -2.44%
+ Complexity 4094 3683 -411
============================================
Files 1779 988 -791
Lines 37794 24283 -13511
Branches 4156 2358 -1798
============================================
- Hits 20469 12560 -7909
+ Misses 16343 10636 -5707
- Partials 982 1087 +105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1290 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.21%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.37% +1.21%
+ Complexity 4094 3882 -212
============================================
Files 1779 988 -791
Lines 37794 24331 -13463
Branches 4156 2361 -1795
============================================
- Hits 20469 13474 -6995
+ Misses 16343 9681 -6662
- Partials 982 1176 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `9.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 44.81% -9.35%
+ Complexity 4094 2674 -1420
============================================
Files 1779 836 -943
Lines 37794 20600 -17194
Branches 4156 1946 -2210
============================================
- Hits 20469 9231 -11238
+ Misses 16343 10661 -5682
+ Partials 982 708 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.52%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.68% +0.52%
+ Complexity 4094 3874 -220
============================================
Files 1779 987 -792
Lines 37794 24418 -13376
Branches 4156 2370 -1786
============================================
- Hits 20469 13352 -7117
+ Misses 16343 9917 -6426
- Partials 982 1149 +167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `12.57%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 50.07% 37.50% -12.58%
+ Complexity 3621 2887 -734
=============================================
Files 999 990 -9
Lines 24478 24107 -371
Branches 2385 2319 -66
=============================================
- Hits 12258 9041 -3217
- Misses 11174 14262 +3088
+ Partials 1046 804 -242
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+6.81%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (a5c618c) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.70%`.
> The diff coverage is `21.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.45% -8.71%
+ Complexity 4094 3122 -972
============================================
Files 1779 1776 -3
Lines 37794 37680 -114
Branches 4156 4153 -3
============================================
- Hits 20469 17128 -3341
- Misses 16343 19598 +3255
+ Partials 982 954 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-17.25%)` | `0.00 <0.00> (-3.00)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `8.80%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 45.19% -8.81%
+ Complexity 4079 2681 -1398
============================================
Files 1779 836 -943
Lines 37794 20543 -17251
Branches 4157 1919 -2238
============================================
- Hits 20408 9284 -11124
+ Misses 16403 10561 -5842
+ Partials 983 698 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.98% <0.00%> (+0.45%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `13.26%`.
> The diff coverage is `62.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 40.89% -13.27%
+ Complexity 4094 2396 -1698
=============================================
Files 1779 806 -973
Lines 37794 19742 -18052
Branches 4156 1862 -2294
=============================================
- Hits 20469 8074 -12395
+ Misses 16343 11049 -5294
+ Partials 982 619 -363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1413 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.26%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.28% +4.26%
+ Complexity 4080 4075 -5
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14266 -6149
+ Misses 16397 8971 -7426
- Partials 982 1239 +257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.42%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.73% -1.43%
+ Complexity 4094 3095 -999
============================================
Files 1779 836 -943
Lines 37794 20821 -16973
Branches 4156 1963 -2193
============================================
- Hits 20469 10979 -9490
+ Misses 16343 8984 -7359
+ Partials 982 858 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `22.57%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 31.58% -22.58%
+ Complexity 4094 2332 -1762
=============================================
Files 1779 957 -822
Lines 37794 23132 -14662
Branches 4156 2204 -1952
=============================================
- Hits 20469 7306 -13163
+ Misses 16343 15201 -1142
+ Partials 982 625 -357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `27.39%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 0.00% 27.39% +27.39%
- Complexity 0 1686 +1686
=============================================
Files 169 805 +636
Lines 4234 19436 +15202
Branches 499 1794 +1295
=============================================
+ Hits 0 5324 +5324
- Misses 4234 13740 +9506
- Partials 0 372 +372
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (ø)` | `4.00 <0.00> (?)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (ø)` | `4.00 <0.00> (?)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (ø)` | `2.00 <1.00> (?)` | |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | | | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | | | |
| [...pm/agent/core/plugin/InstrumentDebuggingClass.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0luc3RydW1lbnREZWJ1Z2dpbmdDbGFzcy5qYXZh) | | | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | | | |
| [...ptor/enhance/InstMethodsInterWithOverrideArgs.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlcldpdGhPdmVycmlkZUFyZ3MuamF2YQ==) | | | |
| ... and [945 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.00%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 53.15% -1.01%
+ Complexity 4094 3921 -173
============================================
Files 1779 1779
Lines 37794 37770 -24
Branches 4156 4153 -3
============================================
- Hits 20469 20076 -393
- Misses 16343 16713 +370
+ Partials 982 981 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [50 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `7.45%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 46.56% -7.46%
+ Complexity 4080 3459 -621
============================================
Files 1779 987 -792
Lines 37794 24346 -13448
Branches 4156 2363 -1793
============================================
- Hits 20415 11337 -9078
+ Misses 16397 12019 -4378
- Partials 982 990 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1296 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `4.49%`.
> The diff coverage is `21.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 49.66% -4.50%
+ Complexity 4094 2983 -1111
============================================
Files 1779 1779
Lines 37794 37798 +4
Branches 4156 4324 +168
============================================
- Hits 20469 18772 -1697
- Misses 16343 18074 +1731
+ Partials 982 952 -30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [114 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `3.06%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 57.08% +3.06%
+ Complexity 4080 4007 -73
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 13959 -6456
+ Misses 16397 9295 -7102
- Partials 982 1200 +218
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3871998) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `24.94%`.
> The diff coverage is `1.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 29.05% -24.95%
=============================================
Files 1779 1681 -98
Lines 37794 35145 -2649
Branches 4157 4622 +465
=============================================
- Hits 20408 10211 -10197
- Misses 16403 23989 +7586
+ Partials 983 945 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `0.00 <0.00> (-9.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-81.14%)` | `0.00 <0.00> (-10.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-8.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-3.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-17.25%)` | `0.00 <0.00> (-3.00)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-38.53%)` | `0.00 <0.00> (-6.00)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `85.71% <100.00%> (-5.47%)` | `0.00 <0.00> (-11.00)` | |
| ... and [847 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...b3f0975](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.66%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.52% +18.66%
- Complexity 2208 3629 +1421
=============================================
Files 971 988 +17
Lines 23644 24414 +770
Branches 2297 2372 +75
=============================================
+ Hits 7296 12091 +4795
+ Misses 15791 11257 -4534
- Partials 557 1066 +509
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `1.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 53.14% +1.00%
- Complexity 3764 3834 +70
============================================
Files 1006 987 -19
Lines 24671 24391 -280
Branches 2403 2368 -35
============================================
+ Hits 12863 12962 +99
+ Misses 10712 10315 -397
- Partials 1096 1114 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `12.21%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 41.94% -12.22%
+ Complexity 4094 3023 -1071
=============================================
Files 1779 958 -821
Lines 37794 23479 -14315
Branches 4156 2277 -1879
=============================================
- Hits 20469 9849 -10620
+ Misses 16343 12784 -3559
+ Partials 982 846 -136
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `23.47%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 54.32% +23.47%
- Complexity 2208 3883 +1675
=============================================
Files 971 988 +17
Lines 23644 24436 +792
Branches 2297 2372 +75
=============================================
+ Hits 7296 13276 +5980
+ Misses 15791 9994 -5797
- Partials 557 1166 +609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `3.67%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 57.83% +3.67%
+ Complexity 4094 4050 -44
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14155 -6314
+ Misses 16343 9087 -7256
- Partials 982 1234 +252
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `20.52%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.37% +20.52%
- Complexity 2208 3637 +1429
=============================================
Files 971 987 +16
Lines 23644 24249 +605
Branches 2297 2354 +57
=============================================
+ Hits 7296 12459 +5163
+ Misses 15791 10744 -5047
- Partials 557 1046 +489
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [387 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `24.92%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 55.78% +24.92%
- Complexity 2208 3960 +1752
=============================================
Files 971 988 +17
Lines 23644 24446 +802
Branches 2297 2373 +76
=============================================
+ Hits 7296 13637 +6341
+ Misses 15791 9614 -6177
- Partials 557 1195 +638
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [413 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.02%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 48.88% +18.02%
- Complexity 2208 3513 +1305
=============================================
Files 971 987 +16
Lines 23644 24234 +590
Branches 2297 2349 +52
=============================================
+ Hits 7296 11847 +4551
+ Misses 15791 11394 -4397
- Partials 557 993 +436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `15.74%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 46.60% +15.74%
- Complexity 2208 3430 +1222
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11369 +4073
+ Misses 15791 12050 -3741
- Partials 557 976 +419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [326 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `4.13%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 56.27% +4.13%
- Complexity 3764 3984 +220
============================================
Files 1006 987 -19
Lines 24671 24401 -270
Branches 2403 2369 -34
============================================
+ Hits 12863 13732 +869
+ Misses 10712 9469 -1243
- Partials 1096 1200 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `1.82%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 55.84% +1.82%
+ Complexity 4080 3939 -141
============================================
Files 1779 988 -791
Lines 37794 24426 -13368
Branches 4156 2368 -1788
============================================
- Hits 20415 13641 -6774
+ Misses 16397 9603 -6794
- Partials 982 1182 +200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.59%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 47.44% +16.59%
- Complexity 2208 3438 +1230
=============================================
Files 971 987 +16
Lines 23644 24234 +590
Branches 2297 2349 +52
=============================================
+ Hits 7296 11499 +4203
+ Misses 15791 11763 -4028
- Partials 557 972 +415
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [348 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `24.44%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 27.99% 52.43% +24.44%
- Complexity 1999 3927 +1928
=============================================
Files 971 1779 +808
Lines 23503 37840 +14337
Branches 2267 4160 +1893
=============================================
+ Hits 6579 19842 +13263
- Misses 16452 17012 +560
- Partials 472 986 +514
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (+49.36%)` | `10.00 <2.00> (+6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1430 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.07%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.08% -8.08%
+ Complexity 4094 3279 -815
============================================
Files 1779 958 -821
Lines 37794 23541 -14253
Branches 4156 2285 -1871
============================================
- Hits 20469 10848 -9621
+ Misses 16343 11758 -4585
+ Partials 982 935 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `10.55%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 43.60% -10.56%
+ Complexity 4094 2636 -1458
=============================================
Files 1779 836 -943
Lines 37794 20623 -17171
Branches 4156 1951 -2205
=============================================
- Hits 20469 8992 -11477
+ Misses 16343 10944 -5399
+ Partials 982 687 -295
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.34%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.81% -7.35%
+ Complexity 4094 3317 -777
============================================
Files 1779 958 -821
Lines 37794 23544 -14250
Branches 4156 2285 -1871
============================================
- Hits 20469 11021 -9448
+ Misses 16343 11590 -4753
+ Partials 982 933 -49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `27.13%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 27.02% -27.14%
+ Complexity 4094 1661 -2433
=============================================
Files 1779 805 -974
Lines 37794 19436 -18358
Branches 4156 1794 -2362
=============================================
- Hits 20469 5253 -15216
+ Misses 16343 13812 -2531
+ Partials 982 371 -611
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1479 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `8.50%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 39.36% +8.50%
- Complexity 2208 2811 +603
============================================
Files 971 957 -14
Lines 23644 23188 -456
Branches 2297 2234 -63
============================================
+ Hits 7296 9127 +1831
+ Misses 15791 13309 -2482
- Partials 557 752 +195
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.17%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.03% +18.17%
- Complexity 2208 3612 +1404
=============================================
Files 971 988 +17
Lines 23644 24414 +770
Branches 2297 2372 +75
=============================================
+ Hits 7296 11971 +4675
+ Misses 15791 11408 -4383
- Partials 557 1035 +478
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.09%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.11% +4.09%
+ Complexity 4080 4070 -10
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14224 -6191
+ Misses 16397 9025 -7372
- Partials 982 1227 +245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `15.86%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 46.72% +15.86%
- Complexity 2208 3400 +1192
=============================================
Files 971 987 +16
Lines 23644 24234 +590
Branches 2297 2349 +52
=============================================
+ Hits 7296 11323 +4027
+ Misses 15791 11952 -3839
- Partials 557 959 +402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `0.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.94% 54.03% +0.08%
+ Complexity 4094 4089 -5
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
+ Hits 20423 20447 +24
+ Misses 16453 16412 -41
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <0.00%> (-2.13%)` | `14.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `97.24% <0.00%> (-1.84%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `14.74%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 39.26% -14.75%
+ Complexity 4080 2437 -1643
=============================================
Files 1779 835 -944
Lines 37794 20561 -17233
Branches 4156 1941 -2215
=============================================
- Hits 20415 8074 -12341
+ Misses 16397 11850 -4547
+ Partials 982 637 -345
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1402 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (cc647b0) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `24.95%`.
> The diff coverage is `1.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 29.04% -24.96%
=============================================
Files 1779 1681 -98
Lines 37794 35149 -2645
Branches 4157 4618 +461
=============================================
- Hits 20408 10208 -10200
- Misses 16403 23995 +7592
+ Partials 983 946 -37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-81.14%)` | `0.00 <0.00> (-10.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-8.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-3.00)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-38.53%)` | `0.00 <0.00> (-6.00)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `85.71% <100.00%> (-5.47%)` | `0.00 <0.00> (-11.00)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [845 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...61cee0f](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `5.25%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 48.90% -5.26%
+ Complexity 4094 3521 -573
============================================
Files 1779 987 -792
Lines 37794 24197 -13597
Branches 4156 2353 -1803
============================================
- Hits 20469 11833 -8636
+ Misses 16343 11356 -4987
- Partials 982 1008 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1306 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 46.86% +16.00%
- Complexity 2208 3437 +1229
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11433 +4137
+ Misses 15791 11975 -3816
- Partials 557 987 +430
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `0.01%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 54.03% +0.01%
- Complexity 4080 4089 +9
============================================
Files 1779 1779
Lines 37794 37840 +46
Branches 4156 4161 +5
============================================
+ Hits 20415 20447 +32
- Misses 16397 16412 +15
+ Partials 982 981 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `60.00% <0.00%> (-1.34%)` | `7.00% <0.00%> (ø%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `69.04% <0.00%> (-1.20%)` | `13.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `6.97%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 47.02% -6.98%
+ Complexity 4079 2708 -1371
============================================
Files 1779 1769 -10
Lines 37794 37398 -396
Branches 4157 4306 +149
============================================
- Hits 20408 17586 -2822
- Misses 16403 18860 +2457
+ Partials 983 952 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.01% <0.00%> (-0.51%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <100.00%> (-11.18%)` | `0.00 <0.00> (-11.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [268 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `17.35%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 36.66% -17.36%
+ Complexity 4080 2303 -1777
=============================================
Files 1779 835 -944
Lines 37794 20551 -17243
Branches 4156 1940 -2216
=============================================
- Hits 20415 7535 -12880
+ Misses 16397 12439 -3958
+ Partials 982 577 -405
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1419 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.00%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 53.15% -1.01%
+ Complexity 4094 3059 -1035
============================================
Files 1779 836 -943
Lines 37794 20690 -17104
Branches 4156 1954 -2202
============================================
- Hits 20469 10997 -9472
+ Misses 16343 8816 -7527
+ Partials 982 877 -105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `12.18%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 51.16% 38.97% -12.19%
+ Complexity 3694 2996 -698
=============================================
Files 1004 990 -14
Lines 24547 24107 -440
Branches 2391 2319 -72
=============================================
- Hits 12559 9396 -3163
- Misses 10916 13877 +2961
+ Partials 1072 834 -238
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+6.81%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `8.48%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 39.34% +8.48%
- Complexity 2208 2810 +602
============================================
Files 971 957 -14
Lines 23644 23188 -456
Branches 2297 2234 -63
============================================
+ Hits 7296 9123 +1827
+ Misses 15791 13313 -2478
- Partials 557 752 +195
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `2.28%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 51.73% -2.29%
+ Complexity 4080 3696 -384
============================================
Files 1779 987 -792
Lines 37794 24263 -13531
Branches 4156 2352 -1804
============================================
- Hits 20415 12552 -7863
+ Misses 16397 10628 -5769
- Partials 982 1083 +101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `0.51%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 53.63% -0.52%
+ Complexity 4094 3089 -1005
============================================
Files 1779 836 -943
Lines 37794 20690 -17104
Branches 4156 1954 -2202
============================================
- Hits 20469 11098 -9371
+ Misses 16343 8701 -7642
+ Partials 982 891 -91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.79%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.36% -2.80%
+ Complexity 4094 3661 -433
============================================
Files 1779 987 -792
Lines 37794 24238 -13556
Branches 4156 2354 -1802
============================================
- Hits 20469 12449 -8020
+ Misses 16343 10723 -5620
- Partials 982 1066 +84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `6.84%`.
> The diff coverage is `25.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 47.15% -6.85%
+ Complexity 4079 3283 -796
============================================
Files 1779 957 -822
Lines 37794 23273 -14521
Branches 4157 2240 -1917
============================================
- Hits 20408 10974 -9434
+ Misses 16403 11368 -5035
+ Partials 983 931 -52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `10.80%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 43.34% -10.81%
+ Complexity 4094 3108 -986
=============================================
Files 1779 958 -821
Lines 37794 23511 -14283
Branches 4156 2282 -1874
=============================================
- Hits 20469 10192 -10277
+ Misses 16343 12460 -3883
+ Partials 982 859 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.85% -1.31%
+ Complexity 4094 3751 -343
============================================
Files 1779 988 -791
Lines 37794 24444 -13350
Branches 4156 2369 -1787
============================================
- Hits 20469 12920 -7549
+ Misses 16343 10445 -5898
- Partials 982 1079 +97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.36%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.79% -8.37%
+ Complexity 4094 3268 -826
============================================
Files 1779 958 -821
Lines 37794 23533 -14261
Branches 4156 2283 -1873
============================================
- Hits 20469 10777 -9692
+ Misses 16343 11845 -4498
+ Partials 982 911 -71
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `7.56%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 46.44% -7.57%
+ Complexity 4080 2800 -1280
============================================
Files 1779 836 -943
Lines 37794 20616 -17178
Branches 4156 1948 -2208
============================================
- Hits 20415 9576 -10839
+ Misses 16397 10289 -6108
+ Partials 982 751 -231
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.86%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.29% -2.87%
+ Complexity 4094 3674 -420
============================================
Files 1779 988 -791
Lines 37794 24444 -13350
Branches 4156 2369 -1787
============================================
- Hits 20469 12538 -7931
+ Misses 16343 10864 -5479
- Partials 982 1042 +60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `0.01%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 54.03% +0.01%
- Complexity 4080 4089 +9
============================================
Files 1779 1779
Lines 37794 37840 +46
Branches 4156 4161 +5
============================================
+ Hits 20415 20447 +32
- Misses 16397 16412 +15
+ Partials 982 981 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `60.00% <0.00%> (-1.34%)` | `7.00% <0.00%> (ø%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `69.04% <0.00%> (-1.20%)` | `13.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [9ad26c3...0aa5171](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `24.21%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 29.80% -24.22%
+ Complexity 4080 1816 -2264
=============================================
Files 1779 805 -974
Lines 37794 19436 -18358
Branches 4156 1794 -2362
=============================================
- Hits 20415 5792 -14623
+ Misses 16397 13218 -3179
+ Partials 982 426 -556
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1464 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `8.14%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 45.86% -8.15%
+ Complexity 4080 2765 -1315
============================================
Files 1779 836 -943
Lines 37794 20616 -17178
Branches 4156 1948 -2208
============================================
- Hits 20415 9456 -10959
+ Misses 16397 10420 -5977
+ Partials 982 740 -242
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.71%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 41.28% -12.72%
+ Complexity 4079 2503 -1576
=============================================
Files 1779 836 -943
Lines 37794 20508 -17286
Branches 4157 1917 -2240
=============================================
- Hits 20408 8466 -11942
+ Misses 16403 11411 -4992
+ Partials 983 631 -352
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-33.44%)` | `1.00 <0.00> (-5.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1379 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **decrease** coverage by `0.11%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.94% 53.83% -0.12%
+ Complexity 4094 4076 -18
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
- Hits 20423 20371 -52
- Misses 16453 16488 +35
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <0.00%> (-56.00%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.87%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 50.73% +19.87%
- Complexity 2208 3609 +1401
=============================================
Files 971 987 +16
Lines 23644 24249 +605
Branches 2297 2354 +57
=============================================
+ Hits 7296 12303 +5007
+ Misses 15791 10918 -4873
- Partials 557 1028 +471
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [387 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `6.77%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 47.24% -6.78%
+ Complexity 4080 3494 -586
============================================
Files 1779 987 -792
Lines 37794 24346 -13448
Branches 4156 2363 -1793
============================================
- Hits 20415 11502 -8913
+ Misses 16397 11840 -4557
- Partials 982 1004 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.50%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.66% +0.50%
+ Complexity 4094 3887 -207
============================================
Files 1779 988 -791
Lines 37794 24462 -13332
Branches 4156 2370 -1786
============================================
- Hits 20469 13373 -7096
+ Misses 16343 9936 -6407
- Partials 982 1153 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `4.80%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 49.19% -4.81%
+ Complexity 4079 2895 -1184
============================================
Files 1779 1779
Lines 37794 37730 -64
Branches 4157 4316 +159
============================================
- Hits 20408 18561 -1847
- Misses 16403 18220 +1817
+ Partials 983 949 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.01% <0.00%> (-0.51%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `88.57% <100.00%> (-2.61%)` | `0.00 <0.00> (-11.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [129 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.34%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.81% -7.35%
+ Complexity 4094 3317 -777
============================================
Files 1779 958 -821
Lines 37794 23544 -14250
Branches 4156 2285 -1871
============================================
- Hits 20469 11022 -9447
+ Misses 16343 11589 -4754
+ Partials 982 933 -49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `4.20%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 49.95% -4.21%
+ Complexity 4094 2870 -1224
============================================
Files 1779 806 -973
Lines 37794 19940 -17854
Branches 4156 1881 -2275
============================================
- Hits 20469 9961 -10508
+ Misses 16343 9197 -7146
+ Partials 982 782 -200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.89%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.26% -1.90%
+ Complexity 4094 2971 -1123
============================================
Files 1779 806 -973
Lines 37794 19976 -17818
Branches 4156 1882 -2274
============================================
- Hits 20469 10441 -10028
+ Misses 16343 8712 -7631
+ Partials 982 823 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.64%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.80% +1.64%
+ Complexity 4094 3909 -185
============================================
Files 1779 988 -791
Lines 37794 24344 -13450
Branches 4156 2361 -1795
============================================
- Hits 20469 13585 -6884
+ Misses 16343 9570 -6773
- Partials 982 1189 +207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1260 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `4.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 56.48% +4.34%
- Complexity 3764 4002 +238
============================================
Files 1006 988 -18
Lines 24671 24446 -225
Branches 2403 2373 -30
============================================
+ Hits 12863 13809 +946
+ Misses 10712 9427 -1285
- Partials 1096 1210 +114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [122 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `4.96%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.14% 47.18% -4.97%
+ Complexity 3764 3491 -273
============================================
Files 1005 991 -14
Lines 24667 24328 -339
Branches 2403 2359 -44
============================================
- Hits 12863 11478 -1385
- Misses 10708 11846 +1138
+ Partials 1096 1004 -92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `21.11%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 33.55% 54.67% +21.11%
- Complexity 2448 3858 +1410
=============================================
Files 1001 988 -13
Lines 24517 24312 -205
Branches 2382 2359 -23
=============================================
+ Hits 8227 13292 +5065
+ Misses 15664 9866 -5798
- Partials 626 1154 +528
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.27% <0.00%> (-52.46%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [360 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.27%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.43% +1.27%
+ Complexity 4094 3887 -207
============================================
Files 1779 988 -791
Lines 37794 24331 -13463
Branches 4156 2361 -1795
============================================
- Hits 20469 13487 -6982
+ Misses 16343 9667 -6676
- Partials 982 1177 +195
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `12.05%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 42.10% -12.06%
+ Complexity 4094 2550 -1544
=============================================
Files 1779 836 -943
Lines 37794 20623 -17171
Branches 4156 1951 -2205
=============================================
- Hits 20469 8684 -11785
+ Misses 16343 11267 -5076
+ Partials 982 672 -310
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `17.46%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 36.69% -17.47%
+ Complexity 4094 2162 -1932
=============================================
Files 1779 806 -973
Lines 37794 19726 -18068
Branches 4156 1862 -2294
=============================================
- Hits 20469 7239 -13230
+ Misses 16343 11942 -4401
+ Partials 982 545 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1428 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `12.27%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 41.88% -12.28%
+ Complexity 4094 2544 -1550
=============================================
Files 1779 836 -943
Lines 37794 20623 -17171
Branches 4156 1951 -2205
=============================================
- Hits 20469 8637 -11832
+ Misses 16343 11324 -5019
+ Partials 982 662 -320
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (a5c618c) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `18.79%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 35.36% -18.80%
+ Complexity 4094 2093 -2001
=============================================
Files 1779 806 -973
Lines 37794 19594 -18200
Branches 4156 1831 -2325
=============================================
- Hits 20469 6930 -13539
+ Misses 16343 12144 -4199
+ Partials 982 520 -462
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1424 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `1.40%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 55.42% +1.40%
+ Complexity 4080 3920 -160
============================================
Files 1779 988 -791
Lines 37794 24426 -13368
Branches 4156 2368 -1788
============================================
- Hits 20415 13538 -6877
+ Misses 16397 9723 -6674
- Partials 982 1165 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1252 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `3.64%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 57.66% +3.64%
+ Complexity 4080 4034 -46
============================================
Files 1779 988 -791
Lines 37794 24454 -13340
Branches 4156 2373 -1783
============================================
- Hits 20415 14101 -6314
+ Misses 16397 9144 -7253
- Partials 982 1209 +227
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `19.72%`.
> The diff coverage is `62.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 34.43% -19.73%
+ Complexity 4094 2090 -2004
=============================================
Files 1779 805 -974
Lines 37794 19696 -18098
Branches 4156 1857 -2299
=============================================
- Hits 20469 6783 -13686
+ Misses 16343 12388 -3955
+ Partials 982 525 -457
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1440 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `4.70%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 48.81% 53.52% +4.70%
- Complexity 3605 4038 +433
============================================
Files 1001 1779 +778
Lines 24662 37840 +13178
Branches 2395 4161 +1766
============================================
+ Hits 12039 20253 +8214
- Misses 11612 16604 +4992
+ Partials 1011 983 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1294 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.40%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 50.26% +19.40%
- Complexity 2208 3573 +1365
=============================================
Files 971 987 +16
Lines 23644 24249 +605
Branches 2297 2354 +57
=============================================
+ Hits 7296 12189 +4893
+ Misses 15791 11040 -4751
- Partials 557 1020 +463
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [378 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (a5c618c) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `9.81%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 44.34% -9.82%
+ Complexity 4094 3122 -972
============================================
Files 1779 957 -822
Lines 37794 23209 -14585
Branches 4156 2234 -1922
============================================
- Hits 20469 10292 -10177
+ Misses 16343 12026 -4317
+ Partials 982 891 -91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **increase** coverage by `2.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.99% 56.98% +2.99%
+ Complexity 4079 799 -3280
============================================
Files 1779 171 -1608
Lines 37794 4157 -33637
Branches 4157 478 -3679
============================================
- Hits 20408 2369 -18039
+ Misses 16403 1486 -14917
+ Partials 983 302 -681
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `18.60% <0.00%> (-55.82%)` | `6.00% <0.00%> (-1.00%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| ... and [1695 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.54%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.61% -7.55%
+ Complexity 4094 3315 -779
============================================
Files 1779 958 -821
Lines 37794 23533 -14261
Branches 4156 2283 -1873
============================================
- Hits 20469 10970 -9499
+ Misses 16343 11639 -4704
+ Partials 982 924 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `20.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 50.93% +20.08%
- Complexity 2208 3719 +1511
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12438 +5142
+ Misses 15791 10900 -4891
- Partials 557 1079 +522
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `8.48%`.
> The diff coverage is `25.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 45.50% -8.49%
+ Complexity 4079 3154 -925
============================================
Files 1779 956 -823
Lines 37794 23213 -14581
Branches 4157 2235 -1922
============================================
- Hits 20408 10564 -9844
+ Misses 16403 11766 -4637
+ Partials 983 883 -100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `14.78%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 37.89% 52.67% +14.78%
- Complexity 2728 3904 +1176
=============================================
Files 1001 1779 +778
Lines 24552 37770 +13218
Branches 2387 4153 +1766
=============================================
+ Hits 9303 19897 +10594
- Misses 14537 16894 +2357
- Partials 712 979 +267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.13%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.29% +1.13%
+ Complexity 4094 3921 -173
============================================
Files 1779 988 -791
Lines 37794 24475 -13319
Branches 4156 2370 -1786
============================================
- Hits 20469 13534 -6935
+ Misses 16343 9768 -6575
- Partials 982 1173 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.00%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 53.15% -1.01%
+ Complexity 4094 3921 -173
============================================
Files 1779 1779
Lines 37794 37770 -24
Branches 4156 4153 -3
============================================
- Hits 20469 20076 -393
- Misses 16343 16713 +370
+ Partials 982 981 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [50 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (a5c618c) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.70%`.
> The diff coverage is `21.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.45% -8.71%
+ Complexity 4094 3122 -972
============================================
Files 1779 1776 -3
Lines 37794 37680 -114
Branches 4156 4153 -3
============================================
- Hits 20469 17128 -3341
- Misses 16343 19598 +3255
+ Partials 982 954 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-17.25%)` | `0.00 <0.00> (-3.00)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.18%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.97% -2.19%
+ Complexity 4094 3016 -1078
============================================
Files 1779 836 -943
Lines 37794 20690 -17104
Branches 4156 1954 -2202
============================================
- Hits 20469 10754 -9715
+ Misses 16343 9080 -7263
+ Partials 982 856 -126
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `1.17%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 53.31% +1.17%
- Complexity 3764 3839 +75
============================================
Files 1006 987 -19
Lines 24671 24391 -280
Branches 2403 2368 -35
============================================
+ Hits 12863 13004 +141
+ Misses 10712 10261 -451
- Partials 1096 1126 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `9.87%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 40.73% +9.87%
- Complexity 2208 2935 +727
============================================
Files 971 958 -13
Lines 23644 23366 -278
Branches 2297 2269 -28
============================================
+ Hits 7296 9517 +2221
+ Misses 15791 13029 -2762
- Partials 557 820 +263
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [220 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `14.81%`.
> The diff coverage is `25.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 39.17% -14.82%
+ Complexity 4079 2792 -1287
=============================================
Files 1779 956 -823
Lines 37794 23204 -14590
Branches 4157 2235 -1922
=============================================
- Hits 20408 9091 -11317
+ Misses 16403 13343 -3060
+ Partials 983 770 -213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-38.53%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `20.17%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.03% +20.17%
- Complexity 2208 3726 +1518
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12461 +5165
+ Misses 15791 10878 -4913
- Partials 557 1078 +521
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [379 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `13.16%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 40.99% -13.17%
+ Complexity 4094 2484 -1610
=============================================
Files 1779 836 -943
Lines 37794 20600 -17194
Branches 4156 1946 -2210
=============================================
- Hits 20469 8445 -12024
+ Misses 16343 11530 -4813
+ Partials 982 625 -357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1388 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.72%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 47.58% +16.72%
- Complexity 2208 3491 +1283
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11608 +4312
+ Misses 15791 11796 -3995
- Partials 557 991 +434
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `7.14%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 46.85% -7.15%
+ Complexity 4079 2696 -1383
============================================
Files 1779 1769 -10
Lines 37794 37398 -396
Branches 4157 4306 +149
============================================
- Hits 20408 17523 -2885
- Misses 16403 18923 +2520
+ Partials 983 952 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.01% <0.00%> (-0.51%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <100.00%> (-11.18%)` | `0.00 <0.00> (-11.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [270 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (cc647b0) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `24.95%`.
> The diff coverage is `1.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 29.04% -24.96%
=============================================
Files 1779 1681 -98
Lines 37794 35149 -2645
Branches 4157 4618 +461
=============================================
- Hits 20408 10208 -10200
- Misses 16403 23995 +7592
+ Partials 983 946 -37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-81.14%)` | `0.00 <0.00> (-10.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-8.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-3.00)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-38.53%)` | `0.00 <0.00> (-6.00)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `85.71% <100.00%> (-5.47%)` | `0.00 <0.00> (-11.00)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [845 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...b3f0975](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.46% +1.30%
+ Complexity 4094 3927 -167
============================================
Files 1779 988 -791
Lines 37794 24475 -13319
Branches 4156 2370 -1786
============================================
- Hits 20469 13574 -6895
+ Misses 16343 9719 -6624
- Partials 982 1182 +200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.72%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 47.58% +16.72%
- Complexity 2208 3491 +1283
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11609 +4313
+ Misses 15791 11796 -3995
- Partials 557 990 +433
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `10.05%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 44.10% -10.06%
+ Complexity 4094 2575 -1519
=============================================
Files 1779 806 -973
Lines 37794 19814 -17980
Branches 4156 1872 -2284
=============================================
- Hits 20469 8739 -11730
+ Misses 16343 10412 -5931
+ Partials 982 663 -319
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **decrease** coverage by `0.11%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.94% 53.83% -0.12%
+ Complexity 4094 4077 -17
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
- Hits 20423 20372 -51
- Misses 16453 16487 +34
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.33% <0.00%> (-56.00%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `0.62%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 53.39% -0.63%
+ Complexity 4080 3788 -292
============================================
Files 1779 988 -791
Lines 37794 24309 -13485
Branches 4156 2360 -1796
============================================
- Hits 20415 12980 -7435
+ Misses 16397 10216 -6181
- Partials 982 1113 +131
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `21.49%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 32.52% -21.50%
+ Complexity 4080 1964 -2116
=============================================
Files 1779 805 -974
Lines 37794 19574 -18220
Branches 4156 1829 -2327
=============================================
- Hits 20415 6366 -14049
+ Misses 16397 12740 -3657
+ Partials 982 468 -514
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1454 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `2.35%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 54.49% +2.35%
- Complexity 3764 3892 +128
============================================
Files 1006 987 -19
Lines 24671 24401 -270
Branches 2403 2369 -34
============================================
+ Hits 12863 13297 +434
+ Misses 10712 9945 -767
- Partials 1096 1159 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `6.57%`.
> The diff coverage is `25.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 47.41% -6.58%
+ Complexity 4079 3306 -773
============================================
Files 1779 958 -821
Lines 37794 23318 -14476
Branches 4157 2244 -1913
============================================
- Hits 20408 11057 -9351
+ Misses 16403 11323 -5080
+ Partials 983 938 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `13.44%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 40.55% -13.45%
+ Complexity 4079 2461 -1618
=============================================
Files 1779 836 -943
Lines 37794 20508 -17286
Branches 4157 1917 -2240
=============================================
- Hits 20408 8317 -12091
+ Misses 16403 11564 -4839
+ Partials 983 627 -356
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-33.44%)` | `1.00 <0.00> (-5.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `11.07%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 42.91% -11.08%
+ Complexity 4079 2570 -1509
=============================================
Files 1779 836 -943
Lines 37794 20511 -17283
Branches 4157 1917 -2240
=============================================
- Hits 20408 8803 -11605
+ Misses 16403 11059 -5344
+ Partials 983 649 -334
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.98% <0.00%> (+0.45%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `28.49%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 25.52% -28.50%
+ Complexity 4080 1551 -2529
=============================================
Files 1779 805 -974
Lines 37794 19491 -18303
Branches 4156 1797 -2359
=============================================
- Hits 20415 4975 -15440
+ Misses 16397 14179 -2218
+ Partials 982 337 -645
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1489 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.37%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.78% -8.38%
+ Complexity 4094 3265 -829
============================================
Files 1779 958 -821
Lines 37794 23533 -14261
Branches 4156 2283 -1873
============================================
- Hits 20469 10774 -9695
+ Misses 16343 11845 -4498
+ Partials 982 914 -68
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 50.20% +19.34%
- Complexity 2208 3671 +1463
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12259 +4963
+ Misses 15791 11092 -4699
- Partials 557 1066 +509
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.40%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.42% +4.40%
- Complexity 4080 4081 +1
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14300 -6115
+ Misses 16397 8926 -7471
- Partials 982 1250 +268
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `2.00%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 52.00% -2.01%
+ Complexity 4080 3719 -361
============================================
Files 1779 988 -791
Lines 37794 24308 -13486
Branches 4156 2356 -1800
============================================
- Hits 20415 12642 -7773
+ Misses 16397 10574 -5823
- Partials 982 1092 +110
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `14.98%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 37.89% 52.87% +14.98%
- Complexity 2728 3943 +1215
=============================================
Files 1001 1779 +778
Lines 24552 37772 +13220
Branches 2387 4153 +1766
=============================================
+ Hits 9303 19972 +10669
- Misses 14537 16822 +2285
- Partials 712 978 +266
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `2.33%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 54.47% +2.33%
- Complexity 3764 3891 +127
============================================
Files 1006 987 -19
Lines 24671 24401 -270
Branches 2403 2369 -34
============================================
+ Hits 12863 13293 +430
+ Misses 10712 9949 -763
- Partials 1096 1159 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [154 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `2.72%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 49.41% -2.73%
+ Complexity 3764 3626 -138
============================================
Files 1006 987 -19
Lines 24671 24349 -322
Branches 2403 2363 -40
============================================
- Hits 12863 12032 -831
- Misses 10712 11280 +568
+ Partials 1096 1037 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [161 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `6.95%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 30.85% 37.81% +6.95%
- Complexity 2208 2741 +533
============================================
Files 971 957 -14
Lines 23644 23178 -466
Branches 2297 2234 -63
============================================
+ Hits 7296 8764 +1468
+ Misses 15791 13679 -2112
- Partials 557 735 +178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [243 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9d6e9cb) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `11.17%`.
> The diff coverage is `25.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 42.82% -11.18%
+ Complexity 4079 2993 -1086
=============================================
Files 1779 956 -823
Lines 37794 23213 -14581
Branches 4157 2235 -1922
=============================================
- Hits 20408 9941 -10467
+ Misses 16403 12446 -3957
+ Partials 983 826 -157
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `17.48%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 36.67% -17.49%
+ Complexity 4094 2160 -1934
=============================================
Files 1779 806 -973
Lines 37794 19718 -18076
Branches 4156 1846 -2310
=============================================
- Hits 20469 7231 -13238
+ Misses 16343 11938 -4405
+ Partials 982 549 -433
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `0.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.94% 54.03% +0.08%
+ Complexity 4094 4089 -5
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
+ Hits 20423 20447 +24
+ Misses 16453 16412 -41
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <0.00%> (-2.13%)` | `14.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `97.24% <0.00%> (-1.84%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `2.72%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 49.41% -2.73%
+ Complexity 3764 3625 -139
============================================
Files 1006 987 -19
Lines 24671 24349 -322
Branches 2403 2363 -40
============================================
- Hits 12863 12031 -832
- Misses 10712 11280 +568
+ Partials 1096 1038 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [162 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `9.64%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 44.35% -9.65%
+ Complexity 4079 2622 -1457
============================================
Files 1779 836 -943
Lines 37794 20521 -17273
Branches 4157 1918 -2239
============================================
- Hits 20408 9102 -11306
+ Misses 16403 10746 -5657
+ Partials 983 673 -310
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.98% <0.00%> (+0.45%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#discussion_r589396288
##########
File path: oap-server/server-fetcher-plugin/prometheus-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/fetcher/prometheus/provider/PrometheusFetcherProvider.java
##########
@@ -62,8 +67,22 @@
private ScheduledExecutorService ses;
+ private final HistogramMetrics histogram;
+
+ private final CounterMetrics errorCounter;
+
public PrometheusFetcherProvider() {
config = new PrometheusFetcherConfig();
+ MetricsCreator metricsCreator = getManager().find(TelemetryModule.NAME)
+ .provider()
+ .getService(MetricsCreator.class);
+ histogram = metricsCreator.createHistogramMetric(
+ "metrics_scratch_latency", "The process latency of metrics scratching",
Review comment:
```suggestion
"metrics_fetcher_latency", "The process latency of metrics scratching",
```
`scratch` -> `fetcher`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.80%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.35% -7.81%
+ Complexity 4094 2754 -1340
============================================
Files 1779 836 -943
Lines 37794 20600 -17194
Branches 4156 1946 -2210
============================================
- Hits 20469 9550 -10919
+ Misses 16343 10319 -6024
+ Partials 982 731 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **increase** coverage by `0.58%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 52.13% 52.72% +0.58%
- Complexity 3764 4002 +238
============================================
Files 1006 1779 +773
Lines 24671 37840 +13169
Branches 2403 4161 +1758
============================================
+ Hits 12863 19950 +7087
- Misses 10712 16915 +6203
+ Partials 1096 975 -121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `21.56%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 52.41% +21.56%
- Complexity 2208 3960 +1752
=============================================
Files 971 1779 +808
Lines 23644 37840 +14196
Branches 2297 4161 +1864
=============================================
+ Hits 7296 19835 +12539
- Misses 15791 17030 +1239
- Partials 557 975 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1398 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.70%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 47.56% +16.70%
- Complexity 2208 3489 +1281
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 11603 +4307
+ Misses 15791 11799 -3992
- Partials 557 993 +436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `20.89%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 51.75% +20.89%
- Complexity 2208 3758 +1550
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12636 +5340
+ Misses 15791 10687 -5104
- Partials 557 1094 +537
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `13.79%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 44.65% +13.79%
- Complexity 2208 3294 +1086
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 10893 +3597
+ Misses 15791 12573 -3218
- Partials 557 929 +372
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `14.79%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 37.89% 52.68% +14.79%
- Complexity 2728 3904 +1176
=============================================
Files 1001 1779 +778
Lines 24552 37770 +13218
Branches 2387 4153 +1766
=============================================
+ Hits 9303 19898 +10595
- Misses 14537 16893 +2356
- Partials 712 979 +267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `13.04%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 43.90% +13.04%
- Complexity 2208 3257 +1049
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 10711 +3415
+ Misses 15791 12773 -3018
- Partials 557 911 +354
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `4.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.21% +4.05%
+ Complexity 4094 818 -3276
============================================
Files 1779 172 -1607
Lines 37794 4202 -33592
Branches 4156 482 -3674
============================================
- Hits 20469 2446 -18023
+ Misses 16343 1444 -14899
+ Partials 982 312 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
| [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `20.63% <0.00%> (-43.43%)` | `6.00% <0.00%> (ø%)` | |
| ... and [1694 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `10.21%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 43.94% -10.22%
+ Complexity 4094 2638 -1456
=============================================
Files 1779 836 -943
Lines 37794 20600 -17194
Branches 4156 1946 -2210
=============================================
- Hits 20469 9052 -11417
+ Misses 16343 10857 -5486
+ Partials 982 691 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1381 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `16.01%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 53.99% 37.98% -16.02%
+ Complexity 4079 2325 -1754
=============================================
Files 1779 836 -943
Lines 37794 20499 -17295
Branches 4157 1917 -2240
=============================================
- Hits 20408 7787 -12621
+ Misses 16403 12118 -4285
+ Partials 983 594 -389
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-38.53%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1389 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `1.63%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 50.49% -1.64%
+ Complexity 3764 3628 -136
============================================
Files 1006 991 -15
Lines 24671 24331 -340
Branches 2403 2359 -44
============================================
- Hits 12863 12287 -576
- Misses 10712 10970 +258
+ Partials 1096 1074 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [190 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `14.74%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 37.89% 52.63% +14.74%
- Complexity 2728 3896 +1168
=============================================
Files 1001 1779 +778
Lines 24552 37770 +13218
Branches 2387 4153 +1766
=============================================
+ Hits 9303 19879 +10576
- Misses 14537 16911 +2374
- Partials 712 980 +268
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.34%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.81% -7.35%
+ Complexity 4094 3317 -777
============================================
Files 1779 958 -821
Lines 37794 23544 -14250
Branches 4156 2285 -1871
============================================
- Hits 20469 11022 -9447
+ Misses 16343 11589 -4754
+ Partials 982 933 -49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `21.29%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 32.86% -21.30%
+ Complexity 4094 1956 -2138
=============================================
Files 1779 805 -974
Lines 37794 19547 -18247
Branches 4156 1827 -2329
=============================================
- Hits 20469 6424 -14045
+ Misses 16343 12670 -3673
+ Partials 982 453 -529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1442 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `7.58%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 46.57% -7.59%
+ Complexity 4094 2761 -1333
============================================
Files 1779 836 -943
Lines 37794 20600 -17194
Branches 4156 1946 -2210
============================================
- Hits 20469 9595 -10874
+ Misses 16343 10273 -6070
+ Partials 982 732 -250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `18.23%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 49.09% +18.23%
- Complexity 2208 3614 +1406
=============================================
Files 971 988 +17
Lines 23644 24414 +770
Branches 2297 2372 +75
=============================================
+ Hits 7296 11986 +4690
+ Misses 15791 11386 -4405
- Partials 557 1042 +485
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `26.62%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.01% 27.39% -26.63%
+ Complexity 4080 1686 -2394
=============================================
Files 1779 805 -974
Lines 37794 19436 -18358
Branches 4156 1794 -2362
=============================================
- Hits 20415 5324 -15091
+ Misses 16397 13740 -2657
+ Partials 982 372 -610
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1473 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `5.12%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 48.88% -5.13%
+ Complexity 4080 3566 -514
============================================
Files 1779 987 -792
Lines 37794 24227 -13567
Branches 4156 2351 -1805
============================================
- Hits 20415 11844 -8571
+ Misses 16397 11360 -5037
- Partials 982 1023 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `8.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 45.85% -8.31%
+ Complexity 4094 2778 -1316
============================================
Files 1779 836 -943
Lines 37794 20644 -17150
Branches 4156 1952 -2204
============================================
- Hits 20469 9466 -11003
+ Misses 16343 10432 -5911
+ Partials 982 746 -236
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `80.95% <ø> (-9.53%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (443c781) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `0.10%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 52.03% -0.11%
+ Complexity 3764 3756 -8
============================================
Files 1006 987 -19
Lines 24671 24369 -302
Branches 2403 2367 -36
============================================
- Hits 12863 12680 -183
+ Misses 10712 10598 -114
+ Partials 1096 1091 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.10% +4.08%
+ Complexity 4080 4068 -12
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14222 -6193
+ Misses 16397 9027 -7370
- Partials 982 1227 +245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1235 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `12.48%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 43.34% +12.48%
- Complexity 2208 3032 +824
=============================================
Files 971 957 -14
Lines 23644 23224 -420
Branches 2297 2235 -62
=============================================
+ Hits 7296 10067 +2771
+ Misses 15791 12319 -3472
- Partials 557 838 +281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [314 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792738460
I think somehow you break tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `21.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 33.55% 54.64% +21.08%
- Complexity 2448 3855 +1407
=============================================
Files 1001 988 -13
Lines 24517 24312 -205
Branches 2382 2359 -23
=============================================
+ Hits 8227 13285 +5058
+ Misses 15664 9872 -5792
- Partials 626 1155 +529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `3.27% <0.00%> (-52.46%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [359 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `13.21%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 39.66% 52.87% +13.21%
- Complexity 2837 3943 +1106
=============================================
Files 1001 1779 +778
Lines 24659 37772 +13113
Branches 2395 4153 +1758
=============================================
+ Hits 9781 19972 +10191
- Misses 14144 16822 +2678
- Partials 734 978 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.23%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.39% +1.23%
+ Complexity 4094 3885 -209
============================================
Files 1779 988 -791
Lines 37794 24331 -13463
Branches 4156 2361 -1795
============================================
- Hits 20469 13479 -6990
+ Misses 16343 9676 -6667
- Partials 982 1176 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **increase** coverage by `4.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.01% 58.10% +4.08%
+ Complexity 4080 4067 -13
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20415 14221 -6194
+ Misses 16397 9027 -7370
- Partials 982 1228 +246
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1235 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **decrease** coverage by `0.41%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.94% 53.52% -0.42%
+ Complexity 4093 4038 -55
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
- Hits 20420 20253 -167
- Misses 16455 16604 +149
- Partials 981 983 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-68.34%)` | `0.00% <0.00%> (-12.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `0.08%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 53.94% 54.03% +0.08%
+ Complexity 4094 4089 -5
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
+ Hits 20423 20447 +24
+ Misses 16453 16412 -41
- Partials 980 981 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <0.00%> (-2.13%)` | `14.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `97.24% <0.00%> (-1.84%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.32%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.48% +0.32%
+ Complexity 4094 3878 -216
============================================
Files 1779 988 -791
Lines 37794 24462 -13332
Branches 4156 2370 -1786
============================================
- Hits 20469 13328 -7141
+ Misses 16343 9988 -6355
- Partials 982 1146 +164
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (68fe77a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `22.25%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 31.90% -22.26%
+ Complexity 4094 2346 -1748
=============================================
Files 1779 957 -822
Lines 37794 23145 -14649
Branches 4156 2204 -1952
=============================================
- Hits 20469 7384 -13085
+ Misses 16343 15117 -1226
+ Partials 982 644 -338
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1427 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `13.49%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 39.66% 53.15% +13.49%
- Complexity 2837 4013 +1176
=============================================
Files 1001 1779 +778
Lines 24659 37840 +13181
Branches 2395 4161 +1766
=============================================
+ Hits 9781 20114 +10333
- Misses 14144 16743 +2599
- Partials 734 983 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `4.33%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 49.66% -4.34%
+ Complexity 4079 2983 -1096
============================================
Files 1779 1779
Lines 37794 37798 +4
Branches 4157 4324 +167
============================================
- Hits 20408 18771 -1637
- Misses 16403 18074 +1671
+ Partials 983 953 -30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.84% <0.00%> (+0.31%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `88.57% <100.00%> (-2.61%)` | `0.00 <0.00> (-11.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [109 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `24.39%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 55.25% +24.39%
- Complexity 2208 3922 +1714
=============================================
Files 971 988 +17
Lines 23644 24446 +802
Branches 2297 2373 +76
=============================================
+ Hits 7296 13508 +6212
+ Misses 15791 9752 -6039
- Partials 557 1186 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [404 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (6a77199) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `2.43%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 51.72% -2.44%
+ Complexity 4094 3684 -410
============================================
Files 1779 988 -791
Lines 37794 24283 -13511
Branches 4156 2358 -1798
============================================
- Hits 20469 12561 -7908
+ Misses 16343 10636 -5707
- Partials 982 1086 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1290 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (9f25954) into [master](https://codecov.io/gh/apache/skywalking/commit/9ad26c397ce4c60f2ce127642f299a1b451303e3?el=desc) (9ad26c3) will **decrease** coverage by `5.23%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.01% 48.78% -5.24%
+ Complexity 4080 3558 -522
============================================
Files 1779 987 -792
Lines 37794 24212 -13582
Branches 4156 2351 -1805
============================================
- Hits 20415 11812 -8603
+ Misses 16397 11372 -5025
- Partials 982 1028 +46
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+11.22%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `3.95%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.10% +3.95%
+ Complexity 4094 4064 -30
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14223 -6246
+ Misses 16343 9011 -7332
- Partials 982 1242 +260
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `8.38%`.
> The diff coverage is `26.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 41.27% 32.89% -8.39%
+ Complexity 2990 2458 -532
============================================
Files 966 960 -6
Lines 23534 23097 -437
Branches 2294 2205 -89
============================================
- Hits 9713 7597 -2116
- Misses 12973 14839 +1866
+ Partials 848 661 -187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-58.70%)` | `4.00 <0.00> (-6.00)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (+6.81%)` | `2.00 <1.00> (-1.00)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **decrease** coverage by `0.42%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.94% 53.52% -0.43%
+ Complexity 4093 4038 -55
============================================
Files 1780 1779 -1
Lines 37856 37840 -16
Branches 4146 4161 +15
============================================
- Hits 20421 20253 -168
- Misses 16455 16604 +149
- Partials 980 983 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-68.34%)` | `0.00% <0.00%> (-12.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `19.29%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 50.15% +19.29%
- Complexity 2208 3666 +1458
=============================================
Files 971 988 +17
Lines 23644 24417 +773
Branches 2297 2372 +75
=============================================
+ Hits 7296 12246 +4950
+ Misses 15791 11101 -4690
- Partials 557 1070 +513
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [387 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.52%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 54.68% +0.52%
+ Complexity 4094 3889 -205
============================================
Files 1779 988 -791
Lines 37794 24462 -13332
Branches 4156 2370 -1786
============================================
- Hits 20469 13376 -7093
+ Misses 16343 9933 -6410
- Partials 982 1153 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `5.65%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 48.50% -5.66%
+ Complexity 4094 3412 -682
============================================
Files 1779 958 -821
Lines 37794 23569 -14225
Branches 4156 2284 -1872
============================================
- Hits 20469 11433 -9036
+ Misses 16343 11173 -5170
+ Partials 982 963 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1314 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `3.54%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 57.70% +3.54%
+ Complexity 4094 4047 -47
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14124 -6345
+ Misses 16343 9126 -7217
- Partials 982 1226 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <ø> (-4.77%)` | `9.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1245 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `13.89%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 44.75% +13.89%
- Complexity 2208 3303 +1095
=============================================
Files 971 988 +17
Lines 23644 24395 +751
Branches 2297 2367 +70
=============================================
+ Hits 7296 10918 +3622
+ Misses 15791 12547 -3244
- Partials 557 930 +373
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.72%`.
> The diff coverage is `49.39%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 54.15% 52.43% -1.73%
+ Complexity 4094 3927 -167
============================================
Files 1779 1779
Lines 37794 37840 +46
Branches 4156 4160 +4
============================================
- Hits 20469 19842 -627
- Misses 16343 17012 +669
- Partials 982 986 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../oap/server/core/query/BrowserLogQueryService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvQnJvd3NlckxvZ1F1ZXJ5U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-1.77%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [54 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (7ae91ba) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `22.35%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 53.21% +22.35%
- Complexity 2208 4007 +1799
=============================================
Files 971 1779 +808
Lines 23644 37840 +14196
Branches 2297 4161 +1864
=============================================
+ Hits 7296 20135 +12839
- Misses 15791 16730 +939
- Partials 557 975 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-4.63%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `79.36% <75.60%> (-3.33%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1399 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (8b6ad74) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `0.85%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.01% +0.85%
+ Complexity 4094 3908 -186
============================================
Files 1779 988 -791
Lines 37794 24475 -13319
Branches 4156 2370 -1786
============================================
- Hits 20469 13465 -7004
+ Misses 16343 9846 -6497
- Partials 982 1164 +182
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1253 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [d61a4ef...6a77199](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `4.33%`.
> The diff coverage is `20.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 49.66% -4.34%
+ Complexity 4079 2983 -1096
============================================
Files 1779 1779
Lines 37794 37798 +4
Branches 4157 4324 +167
============================================
- Hits 20408 18772 -1636
- Misses 16403 18074 +1671
+ Partials 983 952 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `33.33% <ø> (-57.15%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `23.07% <0.00%> (-58.06%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.84% <0.00%> (+0.31%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `70.37% <75.00%> (-0.22%)` | `3.00 <1.00> (ø)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `0.00 <0.00> (-11.00)` | :arrow_up: |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [108 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (813508d) into [master](https://codecov.io/gh/apache/skywalking/commit/0fdb165662a1ae27cbe5f282501beae9cec5406d?el=desc) (0fdb165) will **increase** coverage by `16.80%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
+ Coverage 30.85% 47.66% +16.80%
- Complexity 2208 3450 +1242
=============================================
Files 971 987 +16
Lines 23644 24234 +590
Branches 2297 2349 +52
=============================================
+ Hits 7296 11550 +4254
+ Misses 15791 11704 -4087
- Partials 557 980 +423
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [354 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [0fdb165...813508d](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (600cfe6) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `9.58%`.
> The diff coverage is `18.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 53.99% 44.41% -9.59%
+ Complexity 4079 2628 -1451
============================================
Files 1779 836 -943
Lines 37794 20521 -17273
Branches 4157 1918 -2239
============================================
- Hits 20408 9114 -11294
+ Misses 16403 10730 -5673
+ Partials 983 677 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `24.00% <0.00%> (-57.14%)` | `4.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.98% <0.00%> (+0.45%)` | `6.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...9d6e9cb](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (3b17141) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `17.44%`.
> The diff coverage is `61.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
=============================================
- Coverage 54.15% 36.71% -17.45%
+ Complexity 4094 2163 -1931
=============================================
Files 1779 806 -973
Lines 37794 19727 -18067
Branches 4156 1866 -2290
=============================================
- Hits 20469 7242 -13227
+ Misses 16343 11941 -4402
+ Partials 982 544 -438
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1428 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...68fe77a](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `1.71%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 55.87% +1.71%
+ Complexity 4094 3937 -157
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 13677 -6792
+ Misses 16343 9623 -6720
- Partials 982 1176 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (f89027e) into [master](https://codecov.io/gh/apache/skywalking/commit/ad94caff5f7daf6a90a5b3b1ae9ecaa33fb426d7?el=desc) (ad94caf) will **decrease** coverage by `3.38%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
- Coverage 52.13% 48.75% -3.39%
+ Complexity 3764 3557 -207
============================================
Files 1006 991 -15
Lines 24671 24328 -343
Branches 2403 2359 -44
============================================
- Hits 12863 11860 -1003
- Misses 10712 11423 +711
+ Partials 1096 1045 -51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `28.57% <ø> (-61.91%)` | `4.00 <0.00> (-5.00)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (-6.00)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (-1.93%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-2.05%)` | `10.00 <2.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [ad94caf...f89027e](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6516: Add telemetry data about metrics in, metrics scraping and trace in metrics to zipkin receiver.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#issuecomment-792750934
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=h1) Report
> Merging [#6516](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=desc) (fc6b455) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **increase** coverage by `3.94%`.
> The diff coverage is `62.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6516 +/- ##
============================================
+ Coverage 54.15% 58.10% +3.94%
+ Complexity 4094 4063 -31
============================================
Files 1779 988 -791
Lines 37794 24476 -13318
Branches 4156 2374 -1782
============================================
- Hits 20469 14222 -6247
+ Misses 16343 9011 -7332
- Partials 982 1243 +261
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `90.47% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV1JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjFKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/zipkin/handler/SpanV2JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuVjJKZXR0eUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `73.07% <75.00%> (+2.48%)` | `3.00 <1.00> (ø)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `80.64% <75.60%> (-0.49%)` | `10.00 <2.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `81.48% <76.92%> (-5.19%)` | `6.00 <1.00> (ø)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/6516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=footer). Last update [1a7cc80...fc6b455](https://codecov.io/gh/apache/skywalking/pull/6516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org