You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "tflobbe (via GitHub)" <gi...@apache.org> on 2025/09/23 14:44:34 UTC

[PR] Failing test for early termination in DrillSideways [lucene]

tflobbe opened a new pull request, #15221:
URL: https://github.com/apache/lucene/pull/15221

   ### Description
   Failing test that shows there is no early termination in DrillSideways when the hit collector throws `CollectionTerminatedException`. This test would pass in Lucene 8.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Failing test for early termination in DrillSideways [lucene]

Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe commented on PR #15221:
URL: https://github.com/apache/lucene/pull/15221#issuecomment-3339868149

   Added an implementation using a dedicated collector for DrillSideways that can bubble up the early termination. This works for the sequential case, but it won't work for the concurrent case, since in concurrent, we are collecting directly with the sideways collector. For the concurrent case, each sideways facet collector should early terminate on it's own. 
   A FacetsCollector that early terminates on it's own is something that would even work today without any changes, it's just sometimes difficult to have FacetsCollector know when to terminate, depending on the logic that's triggering that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org