You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Bosschaert (JIRA)" <ji...@apache.org> on 2009/10/16 12:07:31 UTC

[jira] Created: (FELIX-1766) Refactor and enable AdminServiceMBean

Refactor and enable AdminServiceMBean
-------------------------------------

                 Key: FELIX-1766
                 URL: https://issues.apache.org/jira/browse/FELIX-1766
             Project: Felix
          Issue Type: Bug
          Components: Karaf
    Affects Versions: karaf-1.0.0
            Reporter: David Bosschaert


The MBean for the AdminService is currently not registered with the MBean Server. 
Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768185#action_12768185 ] 

David Bosschaert commented on FELIX-1766:
-----------------------------------------

At least that would be consistent :) It could easily be done after applying this patch as this one already provides the management portion of it.

I guess the one reservation I would have is that Karaf is becoming quite large in terms of the number bundles. But if nobody has an issue with that I'd say we should do the refactor as you suggested...

> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>         Attachments: admin-management-assembly.patch, jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-1766.
------------------------------------

       Resolution: Fixed
    Fix Version/s: karaf-1.0.2
         Assignee: Guillaume Nodet

URL: http://svn.apache.org/viewvc?rev=828802&view=rev


> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>            Assignee: Guillaume Nodet
>             Fix For: karaf-1.0.2
>
>         Attachments: admin-management-assembly.patch, jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Bosschaert updated FELIX-1766:
------------------------------------

    Attachment: jmx_4.patch

The attached patch contains an implementation of this. The shape of it is pretty much similar to how this is done for the Features Service MBean: it's in a bundle of its own.

Unit tests included for all new code.

Main thing missing is to make this new bundle part of the assembly.

> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>         Attachments: jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768181#action_12768181 ] 

Guillaume Nodet commented on FELIX-1766:
----------------------------------------

I wonder if we should refactor the admin service as we did for the features service, i.e. split in 3 bundles: service, commands and management.
Thoughts ?

> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>         Attachments: admin-management-assembly.patch, jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767302#action_12767302 ] 

David Bosschaert commented on FELIX-1766:
-----------------------------------------

I am starting to look into this one now...

> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767814#action_12767814 ] 

David Bosschaert edited comment on FELIX-1766 at 10/21/09 10:24 AM:
--------------------------------------------------------------------

The attached patch (jmx_4.patch) contains an implementation of this. The shape of it is pretty much similar to how this is done for the Features Service MBean: it's in a bundle of its own.

Unit tests included for all new code.

Main thing missing is to make this new bundle part of the assembly.

      was (Author: bosschaert):
    The attached patch contains an implementation of this. The shape of it is pretty much similar to how this is done for the Features Service MBean: it's in a bundle of its own.

Unit tests included for all new code.

Main thing missing is to make this new bundle part of the assembly.
  
> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>         Attachments: admin-management-assembly.patch, jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1766) Refactor and enable AdminServiceMBean

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Bosschaert updated FELIX-1766:
------------------------------------

    Attachment: admin-management-assembly.patch

The admin-management-assembly patch contains the bits needed to include the new admin-management bundle in the assembly and make it part of the default startup.

> Refactor and enable AdminServiceMBean
> -------------------------------------
>
>                 Key: FELIX-1766
>                 URL: https://issues.apache.org/jira/browse/FELIX-1766
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>    Affects Versions: karaf-1.0.0
>            Reporter: David Bosschaert
>         Attachments: admin-management-assembly.patch, jmx_4.patch
>
>
> The MBean for the AdminService is currently not registered with the MBean Server. 
> Before it can be registered it needs to be refactored to be more coarse-grained, like the FeaturesServiceMBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.