[GitHub] [hive] zhangbutao commented on a diff in pull request #4292: HIVE-27302: Iceberg: Suport write to iceberg branch

["zhangbutao (via GitHub)" <gi...@apache.org>]

zhangbutao commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1203984008


##########
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java:
##########
@@ -478,7 +478,7 @@ public enum ErrorMsg {
   DATACONNECTOR_NOT_EXISTS(10428, "Dataconnector does not exist:"),
   TIME_TRAVEL_NOT_ALLOWED(10429, "Time travel is not allowed for {0}. Please choose a storage format which supports the feature.", true),
   INVALID_METADATA_TABLE_NAME(10430, "Invalid metadata table name {0}.", true),
-  METADATA_TABLE_NOT_SUPPORTED(10431, "Metadata tables are not supported for table {0}.", true),
+  TABLE_IDENTIFIER_NOT_SUPPORTED(10431, "Table identifier is not supported for table {0}.", true),

Review Comment:
   It essentially means the same thing that this table doesn't support three layer namespace, e.g ` dbName.tblName.metaTable`  or  `dbName.tblName.branch_branchName`.
   
   The previos errors just only considered the iceberg meta table ` dbName.tblName.metaTable`.  here i refined it and I want to use a general term `Table identifier` to say that this table supports three layer namespace
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org