You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "aswinshakil (via GitHub)" <gi...@apache.org> on 2023/09/20 21:26:06 UTC

[GitHub] [ozone] aswinshakil opened a new pull request, #5337: HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

aswinshakil opened a new pull request, #5337:
URL: https://github.com/apache/ozone/pull/5337

   ## What changes were proposed in this pull request?
   
   `SnapshotDeletingService` should use `omSnaphot`'s `KeyManager` and not activeDb's `KeyManager`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-9333
   
   ## How was this patch tested?
   
   Existing Tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] hemantk-12 merged pull request #5337: HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #5337:
URL: https://github.com/apache/ozone/pull/5337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] hemantk-12 commented on pull request #5337: HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5337:
URL: https://github.com/apache/ozone/pull/5337#issuecomment-1734239029

   Thanks for the patch @aswinshakil 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] aswinshakil commented on pull request #5337: HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

Posted by "aswinshakil (via GitHub)" <gi...@apache.org>.
aswinshakil commented on PR #5337:
URL: https://github.com/apache/ozone/pull/5337#issuecomment-1728513040

   In all test case, we use create and delete snapshots with a single bucket and we don't add data to non-snapshot buckets. Add that case should have caught this. I'll add some tests here shortly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] aswinshakil commented on pull request #5337: HDDS-9333. Snapshot should use snapshot's keyManager in optimizeDirDeletesAndSubmitRequest

Posted by "aswinshakil (via GitHub)" <gi...@apache.org>.
aswinshakil commented on PR #5337:
URL: https://github.com/apache/ozone/pull/5337#issuecomment-1730354534

   Looking at the code, I think it should be fine to use Active DB's `Key Manager`. Because the directory is already deleted, iterating over Active DB or Snapshot DB would yield the same result as we can't add or delete anything inside the directory. I'm not sure if there are any other side effects to using Active DB instead of Snapshot DB. But it is better to use Snapshot DB for this purpose so that we don't mess up anything on Active DB. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org