[jira] [Commented] (KYLIN-966) When user creates a cube, if enter a name which already exists, Kylin will thrown expection on last step

["Zhong,Jason (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745207#comment-14745207 ] 

Zhong,Jason commented on KYLIN-966:
-----------------------------------

[~nichunen]

Hi, chunen
I have reviewed your patch, one thing you need to know is that.CubeSchema.js is used in both 'edit' and 'view' model.
so, when you are view Cube, and click 'Next Step', this patch will throw wrong alert.
the field to know the current model is here:

$scope.state = {mode: "view"}; //line 49 in cubeSchema.js



> When user creates a cube, if enter a name which already exists, Kylin will thrown expection on last step
> --------------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-966
>                 URL: https://issues.apache.org/jira/browse/KYLIN-966
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v0.7.2
>            Reporter: Shaofeng SHI
>            Assignee: Zhong,Jason
>             Fix For: v1.1
>
>         Attachments: KYLIN-966.patch
>
>
> Kylin cube wizard should check the uniqueness of the name once user entered it; Otherwise, it will fail on last step when writting to resource store (timestamp wasn' expected); And even if user changes name will not work, finally have to cancel and create from scratch, which is bad. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)