You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/05 09:26:23 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1186: Remove "| O_BINARY" or " |= O_BINARY" since O_BINARY is 0 now

pkarashchenko commented on code in PR #1186:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1186#discussion_r889670978


##########
netutils/ftpd/ftpd.c:
##########
@@ -1809,9 +1809,6 @@ static int ftpd_stream(FAR struct ftpd_session_s *session, int cmdtype)
 #if defined(O_LARGEFILE)
   oflags |= O_LARGEFILE;
 #endif
-#if defined(O_BINARY)

Review Comment:
   Let's check the original canutils code. If it contains this code, then it is better to keep it even if the binary flag is zero



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org