[GitHub] [dolphinscheduler] acongfly commented on a diff in pull request #13183: [Feature] Task monitoring supports task names as tags.

[GitBox <gi...@apache.org>]

acongfly commented on code in PR #13183:
URL: https://github.com/apache/dolphinscheduler/pull/13183#discussion_r1048471000


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/metrics/TaskMetrics.java:
##########
@@ -83,11 +85,31 @@ public void incTaskDispatch() {
         taskDispatchCounter.increment();
     }
 
-    public void incTaskInstanceByState(final String state) {
-        if (taskInstanceCounters.get(state) == null) {
+    public void incTaskInstanceByState(final String state, Integer taskInstanceId) {

Review Comment:
   Thank you for your suggestion. I will redesign this implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org