[jira] [Work logged] (BEAM-4003) Futurize and fix python 2 compatibility for runners subpackage

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=112151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112151 ]

ASF GitHub Bot logged work on BEAM-4003:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jun/18 03:34
            Start Date: 15/Jun/18 03:34
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5373: [BEAM-4003] Futurize runners subpackage
URL: https://github.com/apache/beam/pull/5373#discussion_r195587768
 
 

 ##########
 File path: sdks/python/apache_beam/runners/worker/opcounters_test.py
 ##########
 @@ -149,11 +154,11 @@ def test_update_multiple(self):
     value = GlobalWindows.windowed_value('defghij')
     opcounts.update_from(value)
     total_size += coder.estimate_size(value)
-    self.verify_counters(opcounts, 2, float(total_size) / 2)
+    self.verify_counters(opcounts, 2, (float(total_size) // 2))
     value = GlobalWindows.windowed_value('klmnop')
     opcounts.update_from(value)
     total_size += coder.estimate_size(value)
-    self.verify_counters(opcounts, 3, float(total_size) / 3)
+    self.verify_counters(opcounts, 3, (float(total_size) // 3))
 
 Review comment:
   I think given float converson, this should be /, not //.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 112151)
    Time Spent: 50m  (was: 40m)

> Futurize and fix python 2 compatibility for runners subpackage
> --------------------------------------------------------------
>
>                 Key: BEAM-4003
>                 URL: https://issues.apache.org/jira/browse/BEAM-4003
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)