You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/11 18:29:17 UTC
[GitHub] [maven] michael-o opened a new pull request #381: [MNG-6754] Set the same timestamp in multi module builds
michael-o opened a new pull request #381:
URL: https://github.com/apache/maven/pull/381
Reuse MavenExecutionRequest#getStartTime() for expanded snapshot
versions when deploying to a remote repository throughout the entire
reactor for all modules.
This closes #381
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #381:
URL: https://github.com/apache/maven/pull/381#discussion_r502957670
##########
File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
##########
@@ -113,6 +113,7 @@ public DefaultRepositorySystemSession newRepositorySession( MavenExecutionReques
Map<Object, Object> configProps = new LinkedHashMap<>();
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE, request.isInteractiveMode() );
+ configProps.put( "maven.startTime", request.getStartTime() );
Review comment:
Very good question, likely. The question is where to put it? It is an implementation detail after all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #381:
URL: https://github.com/apache/maven/pull/381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o edited a comment on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-706758391
>
>
> Would it be possible to create an integration test that proves this fix works and fixes the reported problem?
Yes, this requires one. I was thinking how to implement, given that I have little time, it'd take me weeks. I was hoping that those who requested this change would come up with one. That's the least I would expect.
The simplest approach is to find all expected snapshot files in the repo and group all timestamps. If the fix is correct, it should be only one timstamp in the set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #381:
URL: https://github.com/apache/maven/pull/381#discussion_r502957670
##########
File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
##########
@@ -113,6 +113,7 @@ public DefaultRepositorySystemSession newRepositorySession( MavenExecutionReques
Map<Object, Object> configProps = new LinkedHashMap<>();
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE, request.isInteractiveMode() );
+ configProps.put( "maven.startTime", request.getStartTime() );
Review comment:
Very good question, likely. The question is where to put it? because it is an implementation detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-706758391
>
>
> Would it be possible to create an integration test that proves this fix works and fixes the reported problem?
Yes, this requires one. I was thinking how to implement, given that I have little time, it'd take me weeks. I was hoping that hose who requested this change would come up with one. That's the least I would expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-706754573
Would it be possible to create an integration test that proves this fix works and fixes the reported problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o edited a comment on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-706758391
>
>
> Would it be possible to create an integration test that proves this fix works and fixes the reported problem?
Yes, this requires one. I was thinking how to implement, given that I have little time, it'd take me weeks. I was hoping that those who requested this change would come up with one. That's the least I would expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #381:
URL: https://github.com/apache/maven/pull/381#discussion_r502954588
##########
File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
##########
@@ -113,6 +113,7 @@ public DefaultRepositorySystemSession newRepositorySession( MavenExecutionReques
Map<Object, Object> configProps = new LinkedHashMap<>();
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE, request.isInteractiveMode() );
+ configProps.put( "maven.startTime", request.getStartTime() );
Review comment:
Would it make sense to introduce a constant for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-711055615
I have just noticed that this is incomplete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #381: [MNG-6754] Set the same timestamp in multi module builds
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #381:
URL: https://github.com/apache/maven/pull/381#issuecomment-711063828
@hboutemy This is somewhat related to reproducibility. Please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org