You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/09 07:37:44 UTC
[GitHub] [shardingsphere] CLSChenml opened a new pull request, #23432: Fix NPM on Oracle 12.2 when load column metadata
CLSChenml opened a new pull request, #23432:
URL: https://github.com/apache/shardingsphere/pull/23432
Fixes #23013 .
Changes proposed in this pull request:
- Added null value handling to resolve NPM issues when obtaining metadata in Oracle12.2 environment.
- Added unit test for it.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23432: Fix NPM on Oracle 12.2 when load column metadata
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23432:
URL: https://github.com/apache/shardingsphere/pull/23432#issuecomment-1375288056
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23432](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e3480b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0de54e94e65b1260f9d8bf500e5198bd478a2c58?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0de54e9) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23432 +/- ##
============================================
- Coverage 49.83% 49.82% -0.01%
Complexity 2461 2461
============================================
Files 4081 4080 -1
Lines 58280 58276 -4
Branches 9253 9253
============================================
- Hits 29041 29035 -6
- Misses 26683 26684 +1
- Partials 2556 2557 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ema/loader/dialect/OracleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3JhY2xlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `86.90% <100.00%> (+0.15%)` | :arrow_up: |
| [...ontend/executor/ConnectionThreadExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvQ29ubmVjdGlvblRocmVhZEV4ZWN1dG9yR3JvdXAuamF2YQ==) | `73.33% <0.00%> (-13.34%)` | :arrow_down: |
| [...gsphere/agent/core/plugin/jar/PluginJarLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vamFyL1BsdWdpbkphckxvYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../plugin/yaml/loader/PluginConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9sb2FkZXIvUGx1Z2luQ29uZmlndXJhdGlvbkxvYWRlci5qYXZh) | | |
| [...or/config/AdvisorConfigurationRegistryFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL2NvbmZpZy9BZHZpc29yQ29uZmlndXJhdGlvblJlZ2lzdHJ5RmFjdG9yeS5qYXZh) | | |
| [...advisor/yaml/entity/YamlAdvisorsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL3lhbWwvZW50aXR5L1lhbWxBZHZpc29yc0NvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...yaml/swapper/YamlAdvisorsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL3lhbWwvc3dhcHBlci9ZYW1sQWR2aXNvcnNDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | | |
| [...advisor/yaml/entity/YamlPointcutConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL3lhbWwvZW50aXR5L1lhbWxQb2ludGN1dENvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...aml/entity/YamlPointcutParameterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL3lhbWwvZW50aXR5L1lhbWxQb2ludGN1dFBhcmFtZXRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...r/yaml/loader/YamlAdvisorsConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9hZHZpc29yL3lhbWwvbG9hZGVyL1lhbWxBZHZpc29yc0NvbmZpZ3VyYXRpb25Mb2FkZXIuamF2YQ==) | | |
| ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/23432?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23432: Fix NPM on Oracle 12.2 when load column metadata
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23432:
URL: https://github.com/apache/shardingsphere/pull/23432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org