You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/11 04:05:10 UTC

[GitHub] [iotdb] weizihan0110 opened a new pull request #2672: Improve physical plan serialize test

weizihan0110 opened a new pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672


   ![image](https://user-images.githubusercontent.com/15262869/107601322-53e3d600-6c61-11eb-9043-6cef82be3d4f.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] weizihan0110 commented on a change in pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
weizihan0110 commented on a change in pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#discussion_r575648373



##########
File path: Jenkinsfile
##########
@@ -106,7 +106,7 @@ pipeline {
                     // Then run the analysis
                     // 'my-sonarcloud-token' needs to be defined for this job and contains the user token
                     withCredentials([string(credentialsId: 'xiangdong-iotdb-sonarcloud-token', variable: 'SONAR_TOKEN')]) {
-                        sh "mvn verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"
+                        sh "mvn -X verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"

Review comment:
       > do not add "-X"
   
   I wanna see what causes the error. Just for the detailed debug info. I'll delete it after solving the problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] weizihan0110 commented on pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
weizihan0110 commented on pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#issuecomment-779555930


   > I suspect it is caused by some permission issue.
   > As we are not using SonarCloud token directly. Instead, we are using Github secret Token.
   > You can omit it before I find a solution (have to ask help from Apache Infra).
   
   Hi, @jixuan1989. I've already removed "-X" param. And just SonarCloud Report Error left.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#issuecomment-778716422


   I suspect it is caused by some permission issue. 
   As we are not using SonarCloud token directly. Instead, we are using Github secret Token. 
   You can omit it before I find a solution (have to ask help from Apache Infra).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] GLBB commented on pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
GLBB commented on pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#issuecomment-778637402


   I also have this problem
   ```
   Main Linux / ubuntu (11) (pull_request) Failing after 39m — ubuntu (11)
   ```
   if solved, please help me
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#discussion_r575600265



##########
File path: .github/workflows/main-linux.yml
##########
@@ -62,7 +62,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
         run: |
-          mvn -B verify sonar:sonar \
+          mvn -X -B verify sonar:sonar \

Review comment:
       why add "-X" ?

##########
File path: Jenkinsfile
##########
@@ -106,7 +106,7 @@ pipeline {
                     // Then run the analysis
                     // 'my-sonarcloud-token' needs to be defined for this job and contains the user token
                     withCredentials([string(credentialsId: 'xiangdong-iotdb-sonarcloud-token', variable: 'SONAR_TOKEN')]) {
-                        sh "mvn verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"
+                        sh "mvn -X verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"

Review comment:
       do not add "-X"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] weizihan0110 commented on a change in pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
weizihan0110 commented on a change in pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672#discussion_r575648373



##########
File path: Jenkinsfile
##########
@@ -106,7 +106,7 @@ pipeline {
                     // Then run the analysis
                     // 'my-sonarcloud-token' needs to be defined for this job and contains the user token
                     withCredentials([string(credentialsId: 'xiangdong-iotdb-sonarcloud-token', variable: 'SONAR_TOKEN')]) {
-                        sh "mvn verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"
+                        sh "mvn -X verify sonar:sonar -Dsonar.branch.name=master -Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-iotdb -Dsonar.login=${SONAR_TOKEN} -DskipTests"

Review comment:
       > do not add "-X"
   
   Hi, @jixuan1989 . I wanna see what causes the error. Just for the detailed debug info. I'll delete it after solving the problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #2672: [ISSUE-2673] Improve tests in PhysicalPlanSerializeTest

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2672:
URL: https://github.com/apache/iotdb/pull/2672


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org