You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 07:52:24 UTC
[GitHub] [spark] cloud-fan opened a new pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
cloud-fan opened a new pull request #32249:
URL: https://github.com/apache/spark/pull/32249
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`CurrentOrigin` is a thread-local variable to track the original SQL line position in plan/expression. Usually, we set `CurrentOrigin`, create `TreeNode` instances, and reset `CurrentOrigin`.
This PR updates the last step to set `CurrentOrigin` to its previous value, instead of resetting it. This is necessary when we invoke `CurrentOrigin` in a nested way, like with subqueries.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To keep the original SQL line position in the error message in more cases.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, only minor error message changes.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823183328
**[Test build #137685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137685/testReport)** for PR 32249 at commit [`b44429d`](https://github.com/apache/spark/commit/b44429dd4e1e5b70bb922cb279b489337af12886).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823209865
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42213/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823216181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42213/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823157605
Looks fine if the failure fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823216181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42213/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823111207
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32249:
URL: https://github.com/apache/spark/pull/32249#discussion_r616466866
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -74,8 +74,11 @@ object CurrentOrigin {
}
def withOrigin[A](o: Origin)(f: => A): A = {
+ // remember the previous one so it can be reset to this
+ // this way withOrigin can be recursive
Review comment:
is double "this" a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823061830
cc @maropu @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823111207
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823067877
**[Test build #137678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137678/testReport)** for PR 32249 at commit [`b8ef281`](https://github.com/apache/spark/commit/b8ef281da64ba42bb37992603675ecf9c7d6dff7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823212702
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42213/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823401477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137685/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823401477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137685/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32249:
URL: https://github.com/apache/spark/pull/32249#discussion_r616475114
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -74,8 +74,11 @@ object CurrentOrigin {
}
def withOrigin[A](o: Origin)(f: => A): A = {
+ // remember the previous one so it can be reset to this
+ // this way withOrigin can be recursive
Review comment:
it's two sentences 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823363786
thanks for review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823362066
**[Test build #137685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137685/testReport)** for PR 32249 at commit [`b44429d`](https://github.com/apache/spark/commit/b44429dd4e1e5b70bb922cb279b489337af12886).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823153165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823153165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32249:
URL: https://github.com/apache/spark/pull/32249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823067877
**[Test build #137678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137678/testReport)** for PR 32249 at commit [`b8ef281`](https://github.com/apache/spark/commit/b8ef281da64ba42bb37992603675ecf9c7d6dff7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823111172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823183328
**[Test build #137685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137685/testReport)** for PR 32249 at commit [`b44429d`](https://github.com/apache/spark/commit/b44429dd4e1e5b70bb922cb279b489337af12886).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32249: [SPARK-35145][SQL] CurrentOrigin should support nested invoking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32249:
URL: https://github.com/apache/spark/pull/32249#issuecomment-823152508
**[Test build #137678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137678/testReport)** for PR 32249 at commit [`b8ef281`](https://github.com/apache/spark/commit/b8ef281da64ba42bb37992603675ecf9c7d6dff7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org