[GitHub] [shardingsphere-elasticjob] seeger12138 opened a new issue #1883: LiteJobFacade#isExecuteMisfired方法是先从zk获取是否需要分, 再判断misfired是否开启

[GitBox <gi...@apache.org>]

seeger12138 opened a new issue #1883:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883


   ## Feature Request
   
   **The LiteJobFacade#isExecuteMisfired method first obtains whether points are needed from zk`(!isNeedSharding())`, and then judges whether misfired is enabled`configService.load(true).isMisfire()`. This is a performance loss for the misfired configuration that is not turned on.**
   
   ### Is your feature request related to a problem?
   **just suggestion**
   
   ### Describe the feature you would like.
   **Reverse order` !isNeedSharding() && configService.load(true).isMisfire()` -> `configService.load(true).isMisfire() && !isNeedSharding()`. According to the short-circuit characteristics, if the misfired configuration is not turned on, there will be no additional performance loss.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is turned on

[GitBox <gi...@apache.org>]

TeslaCN commented on issue #1883:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883#issuecomment-827593070


   Hi @seeger12138 
   Thanks for your feedback! Are you interested in submitting a PR to fix this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] seeger12138 commented on issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is turned on

[GitBox <gi...@apache.org>]

seeger12138 commented on issue #1883:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883#issuecomment-827618182


   I am very happy to do this. Recently, I will take a detailed look at other places that can be optimized like this issue, and then make a summary and raise a PR together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is turned on

[GitBox <gi...@apache.org>]

TeslaCN closed issue #1883:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org