You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2007/07/23 13:25:51 UTC

svn commit: r558685 - /myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js

Author: weber
Date: Mon Jul 23 04:25:50 2007
New Revision: 558685

URL: http://svn.apache.org/viewvc?view=rev&rev=558685
Log:
(TOBAGO-456) javascript: Tobago.openPopupWithAction() should allow options.
and some minor changes

Modified:
    myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js

Modified: myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js?view=diff&rev=558685&r1=558684&r2=558685
==============================================================================
--- myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js (original)
+++ myfaces/tobago/trunk/theme/standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago.js Mon Jul 23 04:25:50 2007
@@ -265,11 +265,6 @@
   makeOverlaySemitransparent: function() {
     var overlay = Tobago.element(Tobago.page.id + "-overlay");
     if (overlay) {
-      if (navigator.appName.indexOf("Explorer") != -1) {  // IE
-        Tobago.addEventListener(window, "scroll", Tobago.doOverlayScroll);
-      } else {
-        overlay.style.position = "fixed";
-      }
       var img = document.createElement("IMG");
       img.style.width = overlay.clientWidth;
       img.style.height = overlay.clientHeight;
@@ -357,7 +352,7 @@
     }
     this.jsObjects.length = 0;
     delete this.jsObjects;
-    
+
     delete this.page;
     delete this.form;
     delete this.action;
@@ -423,7 +418,7 @@
     * Submitting the page with specified actionId.
     */
   submitAction: function(actionId, transition, target) {
-    if (typeof transition == "undefined") {
+    if (transition === undefined) {
       transition = true;
     }
     LOG.info("transition =" + transition);
@@ -948,7 +943,7 @@
     Tobago.popupResizeStub = null;
   },
 
-  openPopupWithAction: function(popupId, actionId) {
+  openPopupWithAction: function(popupId, actionId, options) {
     var div = Tobago.element(popupId);
     if (div) {
       LOG.warn("something is wrong, doing full reload");
@@ -968,7 +963,11 @@
     }
 
     Tobago.addAjaxComponent(popupId, div.id);
-    Tobago.reloadComponent(popupId, actionId, {createOverlay: false});
+    var newOptions = {createOverlay: false}
+    if (options) {
+      Tobago.extend(newOptions, options);
+    }
+    Tobago.reloadComponent(popupId, actionId, options);
   },
 
 // -------- Util functions ----------------------------------------------------
@@ -1857,6 +1856,7 @@
 
   showFailureMessage: function() {
     //alert('uh oh, it looks like the network is down. Try again shortly');
+    LOG.info("ajax request failed!");
   }
 };