You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2024/03/22 17:14:59 UTC
[PR] Fix release docs for the helm chart [airflow]
jedcunningham opened a new pull request, #38413:
URL: https://github.com/apache/airflow/pull/38413
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix release docs for the helm chart [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #38413:
URL: https://github.com/apache/airflow/pull/38413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix release docs for the helm chart [airflow]
Posted by "enchant3dmango (via GitHub)" <gi...@apache.org>.
enchant3dmango commented on code in PR #38413:
URL: https://github.com/apache/airflow/pull/38413#discussion_r1535967153
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number: int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
The TYPE_MAPPING has 5 key-value pairs in it.
So this change might have a different result from the previous code which only checks if the line equals "New Features". Could you explain this change, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix release docs for the helm chart [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #38413:
URL: https://github.com/apache/airflow/pull/38413#discussion_r1535975928
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number: int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
It's quite obvious - the code will fail if there are no New Features (like in 1.13.1
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number: int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
It's quite obvious - the old code will fail if there are no New Features (like in 1.13.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org