You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/24 11:39:14 UTC

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1063: fix: when create a route without ID in request body by Admin API, it can't be displayed in Manager API

tokers commented on a change in pull request #1063:
URL: https://github.com/apache/apisix-dashboard/pull/1063#discussion_r548472804



##########
File path: api/internal/core/storage/storage.go
##########
@@ -33,6 +33,11 @@ type WatchResponse struct {
 	Canceled bool
 }
 
+type Data struct {

Review comment:
       What about `Keypair`?

##########
File path: api/internal/core/storage/storage_mock.go
##########
@@ -1,5 +1,19 @@
-// Code generated by mockery v1.0.0. DO NOT EDIT.
-
+/*

Review comment:
       It is a auto-generated file, why not re-generate it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org