You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "priyeshkaratha (via GitHub)" <gi...@apache.org> on 2026/02/03 04:35:38 UTC
[PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
priyeshkaratha opened a new pull request, #9700:
URL: https://github.com/apache/ozone/pull/9700
## What changes were proposed in this pull request?
This pull request enhances the StorageDistributionEndpoint by incorporating detailed filesystem usage metrics, including capacity, available, and used space, into the datanode storage reports. Current report gives zero values.
- Filesystem Metrics Integration: This pull request integrates filesystem-level capacity, available, and used space metrics into the DatanodeStorageReport object, providing a more granular view of storage.
- Storage Distribution Endpoint Enhancement: The StorageDistributionEndpoint has been updated to retrieve and include these new filesystem metrics when generating storage reports for individual datanodes.
## What is the link to the Apache JIRA
HDDS-14533
## How was this patch tested?
Tested with updated integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #9700:
URL: https://github.com/apache/ozone/pull/9700#discussion_r2757408745
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestStorageDistributionEndpoint.java:
##########
@@ -229,6 +229,8 @@ private boolean verifyStorageDistributionAfterKeyCreation() {
assertEquals(report.getRemaining(), scmReport.getRemaining());
assertEquals(report.getUsed(), scmReport.getUsed());
assertEquals(report.getCommitted(), scmReport.getCommitted());
+ assertEquals(report.getFilesystemAvailable(), scmReport.getFsAvailable());
Review Comment:
Nitpick for future pull requests: Since `scmReport` is the correct expected value, it should be the first argument in `assertEquals`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on code in PR #9700:
URL: https://github.com/apache/ozone/pull/9700#discussion_r2757506605
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestStorageDistributionEndpoint.java:
##########
@@ -229,6 +229,8 @@ private boolean verifyStorageDistributionAfterKeyCreation() {
assertEquals(report.getRemaining(), scmReport.getRemaining());
assertEquals(report.getUsed(), scmReport.getUsed());
assertEquals(report.getCommitted(), scmReport.getCommitted());
+ assertEquals(report.getFilesystemAvailable(), scmReport.getFsAvailable());
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu merged PR #9700:
URL: https://github.com/apache/ozone/pull/9700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on PR #9700:
URL: https://github.com/apache/ozone/pull/9700#issuecomment-3839439722
@siddhantsangwan Thanks for the review
> Does the Recon frontend show data from the storage distribution endpoint yet? If yes, it's worth checking whether Recon is showing the new fs stats correctly.
Currently these information is not used in Capacity page. It will included in the UI as part of https://issues.apache.org/jira/browse/HDDS-14552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14533. Include filesystem metrics in storage Distribution endpoint [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #9700:
URL: https://github.com/apache/ozone/pull/9700#issuecomment-3845187765
Thank you @siddhantsangwan for the review and thanks @priyeshkaratha for the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org