[jira] [Commented] (FLINK-4248) CsvTableSource does not support reading SqlTimeTypeInfo types

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506812#comment-15506812 ] 

ASF GitHub Bot commented on FLINK-4248:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2303#discussion_r79632225
  
    --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/SqlDateParserTest.java ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +package org.apache.flink.types.parser;
    +
    +
    +import java.sql.Date;
    +
    +public class SqlDateParserTest extends ParserTestBase<Date> {
    +
    +	@Override
    +	public String[] getValidTestValues() {
    +		return new String[] {
    +			"1970-01-01", "1990-10-14", "2013-08-12", "2040-05-12", "2040-5-12", "1970-1-1",
    +		};
    +	}
    +
    +	@Override
    +	public Date[] getValidTestResults() {
    +		return new Date[] {
    +			Date.valueOf("1970-01-01"), Date.valueOf("1990-10-14"), Date.valueOf("2013-08-12"),
    +			Date.valueOf("2040-05-12"), Date.valueOf("2040-05-12"), Date.valueOf("1970-01-01")
    +		};
    +	}
    +
    +	@Override
    +	public String[] getInvalidTestValues() {
    +		return new String[] {
    +			" 2013-08-12", "2013-08-12 ", "2013-08--12", "13-08-12", "2013/08/12", " ", "\t",
    --- End diff --
    
    The Java SQL date parser supports this and converts this into "2000-03-01".


> CsvTableSource does not support reading SqlTimeTypeInfo types
> -------------------------------------------------------------
>
>                 Key: FLINK-4248
>                 URL: https://issues.apache.org/jira/browse/FLINK-4248
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Timo Walther
>
> The Table API's {{CsvTableSource}} does not support to read all Table API supported data types. For example, it is not possible to read {{SqlTimeTypeInfo}} types via the {{CsvTableSource}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)