You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2003/04/08 19:13:46 UTC

mailer.py: TypeError in apply_textdelta

Running with svn revision 5583, I'm trying mailer.py for the first
time and getting this error:

$ ./mailer.py /export/home2/svn/repositories/test 1 ./mailer.conf
Traceback (most recent call last):
  File "./mailer.py", line 799, in ?
    svn.util.run_app(main, config_fname, repos_dir, revision)
  File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
  File "./mailer.py", line 48, in main
    pool)
TypeError: apply_textdelta() takes exactly 4 arguments (3 given)

Any ideas?  I have no python/swig fu....

Best,
Blair

-- 
Blair Zajac <bl...@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: mailer.py: TypeError in apply_textdelta

Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
> 
> Blair Zajac <bl...@orcaware.com> writes:
> > That one worked, but now I get this:
> >
> > Traceback (most recent call last):
> >   File "./mailer.py", line 799, in ?
> >     svn.util.run_app(main, config_fname, repos_dir, revision)
> >   File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
> >   File "./mailer.py", line 48, in main
> >     pool)
> > TypeError: close_file() takes exactly 2 arguments (3 given)
> 
> Hmmm, that's a bit different.  close_file() isn't defined in
> mailer.py's ChangeCollector class, so it must be inheriting
> close_file() from svn.delta.Editor...
> 
> Aha!  I think I see it.  The problem was in
> 
>    subversion/bindings/swig/python/svn/delta.py
> 
> Fix committed in revision 5587, awaiting your feedback.

Worked like a charm!

Thanks,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: mailer.py: TypeError in apply_textdelta

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> That one worked, but now I get this:
> 
> Traceback (most recent call last):
>   File "./mailer.py", line 799, in ?
>     svn.util.run_app(main, config_fname, repos_dir, revision)
>   File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
>   File "./mailer.py", line 48, in main
>     pool)
> TypeError: close_file() takes exactly 2 arguments (3 given)

Hmmm, that's a bit different.  close_file() isn't defined in
mailer.py's ChangeCollector class, so it must be inheriting
close_file() from svn.delta.Editor...

Aha!  I think I see it.  The problem was in

   subversion/bindings/swig/python/svn/delta.py  

Fix committed in revision 5587, awaiting your feedback.

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: mailer.py: TypeError in apply_textdelta

Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
> 
> Blair Zajac <bl...@orcaware.com> writes:
> > Running with svn revision 5583, I'm trying mailer.py for the first
> > time and getting this error:
> >
> > $ ./mailer.py /export/home2/svn/repositories/test 1 ./mailer.conf
> > Traceback (most recent call last):
> >   File "./mailer.py", line 799, in ?
> >     svn.util.run_app(main, config_fname, repos_dir, revision)
> >   File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
> >   File "./mailer.py", line 48, in main
> >     pool)
> > TypeError: apply_textdelta() takes exactly 4 arguments (3 given)
> >
> > Any ideas?  I have no python/swig fu....
> 
> This is probably related to revision 5554, where apply_textdelta()
> lost the result_checksum argument.  The bindings got adjusted, but not
> all users of the bindings got adjusted.
> 
> I've committed a fix in revision 5586, let me know how it works.
> 
> -Karl

That one worked, but now I get this:

Traceback (most recent call last):
  File "./mailer.py", line 799, in ?
    svn.util.run_app(main, config_fname, repos_dir, revision)
  File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
  File "./mailer.py", line 48, in main
    pool)
TypeError: close_file() takes exactly 2 arguments (3 given)

Best,
Blair

-- 
Blair Zajac <bl...@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: mailer.py: TypeError in apply_textdelta

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> Running with svn revision 5583, I'm trying mailer.py for the first
> time and getting this error:
> 
> $ ./mailer.py /export/home2/svn/repositories/test 1 ./mailer.conf
> Traceback (most recent call last):
>   File "./mailer.py", line 799, in ?
>     svn.util.run_app(main, config_fname, repos_dir, revision)
>   File "/opt/i386-linux/installed/subversion-r5583/lib/svn-python/svn/util.py", line 38, in run_app
>   File "./mailer.py", line 48, in main
>     pool)
> TypeError: apply_textdelta() takes exactly 4 arguments (3 given)
> 
> Any ideas?  I have no python/swig fu....

This is probably related to revision 5554, where apply_textdelta()
lost the result_checksum argument.  The bindings got adjusted, but not
all users of the bindings got adjusted.

I've committed a fix in revision 5586, let me know how it works.

-Karl



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org