[jira] [Issue Comment Deleted] (MESOS-4598) Logrotate ContainerLogger should not remove IP from environment.

["Till Toenshoff (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Toenshoff updated MESOS-4598:
----------------------------------
    Comment: was deleted

(was: {noformat}
commit aa76317e4da9282e04b7f1eddf0f8768f1c15c3a
Author: Joseph Wu <jo...@mesosphere.io>
Date:   Fri Feb 5 03:54:24 2016 +0100

    Don't remove IP from the logger's environment.

    Unsetting the `LIBPROCESS_IP` was originally unnecessary, as this
    variable does not result in port conflicts.  Unsetting this environment
    variable may cause the subprocess to exit if DNS cannot resolve the
    agent's hostname.

    Review: https://reviews.apache.org/r/43207/
{noformat})

> Logrotate ContainerLogger should not remove IP from environment.
> ----------------------------------------------------------------
>
>                 Key: MESOS-4598
>                 URL: https://issues.apache.org/jira/browse/MESOS-4598
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.27.0
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>              Labels: mesosphere
>
> The {{LogrotateContainerLogger}} starts libprocess-using subprocesses.  Libprocess initialization will attempt to resolve the IP from the hostname.  If a DNS service is not available, this step will fail, which terminates the logger subprocess prematurely.
> Since the logger subprocesses live on the agent, they should use the same {{LIBPROCESS_IP}} supplied to the agent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)