You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Fedotov (JIRA)" <ji...@apache.org> on 2019/04/01 15:08:00 UTC
[jira] [Commented] (IGNITE-11413) Remove beforeTestsStarted,
afterTestsStarted from JUnit3TestLegacySupport
[ https://issues.apache.org/jira/browse/IGNITE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806888#comment-16806888 ]
Ivan Fedotov commented on IGNITE-11413:
---------------------------------------
[~Pavlukhin], let's move conversation thread from [IGNITE-11411|https://issues.apache.org/jira/browse/IGNITE-11411] here as more appropriate.
As I understood from our conversation on dev-list [1], we inject the main before/after test logic under Rule annotation. And it seems that before/after test class methods also could be remained under ClassRule annotation to make as
less as possible changes in already existing tests.
What do you think about such strategy?
[1][http://apache-ignite-developers.2346864.n4.nabble.com/beforeTest-afterTest-JUnit-scenario-implementation-td41396.html]
> Remove beforeTestsStarted, afterTestsStarted from JUnit3TestLegacySupport
> -------------------------------------------------------------------------
>
> Key: IGNITE-11413
> URL: https://issues.apache.org/jira/browse/IGNITE-11413
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
>
> beforeTestsStarted and afterTestsStarted methods are deprecated in context of JUnit4 functional. The 4th version provides @BeforeClass, @AfterClass annotations for such purposes. Methods must be moved in corresponded classes and marked by annotations.
> It could require changes in start/stop nodes process because methods under @BeforeClass, @AfterClass annotations must be static.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)