You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2016/06/22 16:56:52 UTC

[1/3] mesos git commit: Updated upgrades.md about persistent volume ownership issue.

Repository: mesos
Updated Branches:
  refs/heads/master e01a6b13c -> 87cf5bc54


Updated upgrades.md about persistent volume ownership issue.

Review: https://reviews.apache.org/r/49053


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/87cf5bc5
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/87cf5bc5
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/87cf5bc5

Branch: refs/heads/master
Commit: 87cf5bc54b48dfda49ec7071881daef902fb26b1
Parents: 952fb53
Author: Jie Yu <yu...@gmail.com>
Authored: Tue Jun 21 16:52:45 2016 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Wed Jun 22 09:56:44 2016 -0700

----------------------------------------------------------------------
 docs/upgrades.md | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/87cf5bc5/docs/upgrades.md
----------------------------------------------------------------------
diff --git a/docs/upgrades.md b/docs/upgrades.md
index 963b7d4..be3bd27 100644
--- a/docs/upgrades.md
+++ b/docs/upgrades.md
@@ -53,6 +53,7 @@ We categorize the changes as follows:
       <li>C <a href="#1-0-x-quota-acls">Quota ACLs</a></li>
       <li>R <a href="#1-0-x-executor-environment-variables">Executor environment variables inheritance</a></li>
       <li>R <a href="#1-0-x-deprecated-fields-in-container-config">Deprecated fields in ContainerConfig</a></li>
+      <li>C <a href="#1-0-x-persistent-volume-ownership">Persistent volume ownership</a></li>
     </ul>
   </td>
   <td style="word-wrap: break-word; overflow-wrap: break-word;"><!--Flags-->
@@ -174,6 +175,10 @@ We categorize the changes as follows:
 
 ## Upgrading from 0.28.x to 1.0.x ##
 
+<a name="1-0-x-persistent-volume-ownership"</a>
+
+* Prior to Mesos 1.0, Mesos agent recursively changes the ownership of the persistent volumes every time they are mounted to a container. From Mesos 1.0, this behavior has been changed. Mesos agent will do a _non-recursive_ change of ownership of the persistent volumes.
+
 <a name="1-0-x-deprecated-fields-in-container-config"</a>
 
 * Mesos 1.0 removed the camel cased protobuf fields in `ContainerConfig` (see `include/mesos/slave/isolator.proto`):


[3/3] mesos git commit: Used non recursive chown for persistent volumes.

Posted by ji...@apache.org.
Used non recursive chown for persistent volumes.

Review: https://reviews.apache.org/r/49045


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0eb33980
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0eb33980
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0eb33980

Branch: refs/heads/master
Commit: 0eb33980a469f18d1bf4faecde1725651c563ee2
Parents: e01a6b1
Author: Jie Yu <yu...@gmail.com>
Authored: Tue Jun 21 13:45:35 2016 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Wed Jun 22 09:56:44 2016 -0700

----------------------------------------------------------------------
 src/slave/containerizer/docker.cpp                           | 2 +-
 src/slave/containerizer/mesos/isolators/filesystem/linux.cpp | 2 +-
 src/slave/containerizer/mesos/isolators/filesystem/posix.cpp | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/0eb33980/src/slave/containerizer/docker.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/docker.cpp b/src/slave/containerizer/docker.cpp
index a87a87a..514268f 100644
--- a/src/slave/containerizer/docker.cpp
+++ b/src/slave/containerizer/docker.cpp
@@ -518,7 +518,7 @@ Try<Nothing> DockerContainerizerProcess::updatePersistentVolumes(
               << source << "' with uid " << s.st_uid
               << " and gid " << s.st_gid;
 
-    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, source, true);
+    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, source, false);
     if (chown.isError()) {
       return Error(
           "Failed to change the ownership of the persistent volume at '" +

http://git-wip-us.apache.org/repos/asf/mesos/blob/0eb33980/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
index 37b0239..adacde1 100644
--- a/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
+++ b/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
@@ -562,7 +562,7 @@ Future<Nothing> LinuxFilesystemIsolatorProcess::update(
               << source << "' with uid " << s.st_uid
               << " and gid " << s.st_gid;
 
-    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, source, true);
+    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, source, false);
     if (chown.isError()) {
       return Failure(
           "Failed to change the ownership of the persistent volume at '" +

http://git-wip-us.apache.org/repos/asf/mesos/blob/0eb33980/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp b/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
index d45166f..0809e8e 100644
--- a/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
+++ b/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
@@ -195,7 +195,7 @@ Future<Nothing> PosixFilesystemIsolatorProcess::update(
               << original << "' with uid " << s.st_uid
               << " and gid " << s.st_gid;
 
-    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, original, true);
+    Try<Nothing> chown = os::chown(s.st_uid, s.st_gid, original, false);
     if (chown.isError()) {
       return Failure(
           "Failed to change the ownership of the persistent volume at '" +


[2/3] mesos git commit: Updated CHANGELOG about the persistent volume ownership change.

Posted by ji...@apache.org.
Updated CHANGELOG about the persistent volume ownership change.

Review: https://reviews.apache.org/r/49051


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/952fb53f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/952fb53f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/952fb53f

Branch: refs/heads/master
Commit: 952fb53fad45aa6cbbb75fadfd183241b2399ca0
Parents: 0eb3398
Author: Jie Yu <yu...@gmail.com>
Authored: Tue Jun 21 16:18:27 2016 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Wed Jun 22 09:56:44 2016 -0700

----------------------------------------------------------------------
 CHANGELOG | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/952fb53f/CHANGELOG
----------------------------------------------------------------------
diff --git a/CHANGELOG b/CHANGELOG
index e8cc37e..5944f2a 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -165,6 +165,9 @@ Additional API Changes:
   * [MESOS-5657] - Executors should not inherit environment variables from the
     agent.
 
+  * [MESOS-5680] - We should not 'chown -R' on persistent volumes every time
+    container tries to use it.
+
 3rd Party Upgrades:
   * [MESOS-4805] - Upgraded vendored ry-http-parser-1c3624a to nodejs/http-parser 2.6.1.
   * [MESOS-4678] - Upgraded vendored protobuf 2.5.0 to 2.6.1.