You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Ciaran Wood (JIRA)" <ji...@apache.org> on 2009/05/27 12:04:45 UTC
[jira] Created: (TAP5-722) Tapestry ajax form swallows server-side
errors
Tapestry ajax form swallows server-side errors
----------------------------------------------
Key: TAP5-722
URL: https://issues.apache.org/jira/browse/TAP5-722
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Ciaran Wood
I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
The form has its zone parameter set) will never notify the user if the
server-side action fails. I've traced it down to this line in tapestry.js:
// Set a default failure handler if none is provided.
options.onFailure |= Tapestry.ajaxFailureHandler;
This line is in the sendAjaxRequest function that gets added to all form
elements via Prototype's Element.addMethods function. I used firebug to
debug the above statement and instead of the OR assignment that it looks
like, options.onFailure actually ends up being assigned the value '0'. I
guess this means that its only a bitwise operation and can't be used for
functions etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-722) Tapestry ajax form swallows server-side
errors
Posted by "Ciaran Wood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ciaran Wood updated TAP5-722:
-----------------------------
Attachment: TAP-722.patch
Added patch for 5.1.0.5 release tag source
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856181#action_12856181 ]
Leonard Lu edited comment on TAP5-722 at 4/12/10 5:23 PM:
----------------------------------------------------------
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863?
was (Author: lwlu98):
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863 (https://issues.apache.org/jira/browse/TAP5-863)?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (TAP5-722) Tapestry ajax form swallows server-side
errors
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Cordenier reassigned TAP5-722:
-----------------------------------------
Assignee: Christophe Cordenier
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Assignee: Christophe Cordenier
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-722) Tapestry ajax form swallows server-side
errors
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Cordenier reassigned TAP5-722:
-----------------------------------------
Assignee: Christophe Cordenier
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Assignee: Christophe Cordenier
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856181#action_12856181 ]
Leonard Lu commented on TAP5-722:
---------------------------------
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863 (https://issues.apache.org/jira/browse/TAP5-863)?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Ciaran Wood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856336#action_12856336 ]
Ciaran Wood commented on TAP5-722:
----------------------------------
>From the looks of that revision diff you linked to, the offending line of code has gone. My patch included a selenium test to test this behaviour, maybe this could be added to the test suite?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856181#action_12856181 ]
Leonard Lu edited comment on TAP5-722 at 4/12/10 5:23 PM:
----------------------------------------------------------
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863?
was (Author: lwlu98):
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863 (https://issues.apache.org/jira/browse/TAP5-863)?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TAP5-722) Tapestry ajax form swallows server-side
errors
Posted by "Ciaran Wood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ciaran Wood updated TAP5-722:
-----------------------------
Attachment: TAP-722.patch
Added patch for 5.1.0.5 release tag source
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856181#action_12856181 ]
Leonard Lu commented on TAP5-722:
---------------------------------
Is this issue fixed by revision 924025 (http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?r1=922440&r2=924025) for issue TAP5-863 (https://issues.apache.org/jira/browse/TAP5-863)?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-722) Tapestry ajax form swallows
server-side errors
Posted by "Ciaran Wood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856336#action_12856336 ]
Ciaran Wood commented on TAP5-722:
----------------------------------
>From the looks of that revision diff you linked to, the offending line of code has gone. My patch included a selenium test to test this behaviour, maybe this could be added to the test suite?
> Tapestry ajax form swallows server-side errors
> ----------------------------------------------
>
> Key: TAP5-722
> URL: https://issues.apache.org/jira/browse/TAP5-722
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Ciaran Wood
> Attachments: TAP-722.patch
>
>
> I've encountered a bug in T5.1.0.5 where a form that submits via ajax (i.e.
> The form has its zone parameter set) will never notify the user if the
> server-side action fails. I've traced it down to this line in tapestry.js:
> // Set a default failure handler if none is provided.
> options.onFailure |= Tapestry.ajaxFailureHandler;
> This line is in the sendAjaxRequest function that gets added to all form
> elements via Prototype's Element.addMethods function. I used firebug to
> debug the above statement and instead of the OR assignment that it looks
> like, options.onFailure actually ends up being assigned the value '0'. I
> guess this means that its only a bitwise operation and can't be used for
> functions etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira