You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/02/22 04:41:36 UTC

[GitHub] [buildstream] gtristan opened a new pull request #1595: Remove SandboxFlags from public API surface

gtristan opened a new pull request #1595:
URL: https://github.com/apache/buildstream/pull/1595


   The SandboxFlags expose internal details that are not suitable for
   consumption by plugin authors.
   
   Change summary:
   
     * sandbox/sandbox.py: Remove SandboxFlags as argument in public API
       surfaces, and expose a boolean `root_read_only` argument instead,
       while providing an internal `Sandbox._run_with_flags()` API for
       internal use.
   
     * __init__.py, sandbox/__init__.py:
       Updated to remove SandboxFlags from public API
   
     * buildelement.py, scriptelement.py, plugins/elements/autotools.py,
       plugins/elements/compose.py, plugins/elements/manual.py:
       Stop using SandboxFlags, use `root_read_only` parameter instead.
   
     * element.py: Adapt to API changes, use internal `_run_with_flags()` only
       for special cases such as running shells.
   
     * sandbox/_sandboxbuildboxrun.py, sandbox/_sandboxdummy.py,
       sandbox/_sandboxreapi.py: Adapt to API changes
   
   Fixes #265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan merged pull request #1595: Remove SandboxFlags from public API surface

Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1595:
URL: https://github.com/apache/buildstream/pull/1595


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan commented on pull request #1595: Remove SandboxFlags from public API surface

Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1595:
URL: https://github.com/apache/buildstream/pull/1595#issuecomment-1047420175


   Ran CI locally, including linting, format checking, docs and integration tests.
   
   Bypassing CI again while CI remains broken.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org