You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/19 22:23:54 UTC

[GitHub] [helix] xyuanlu commented on a change in pull request #1293: Replace org.codehaus.jackson with FasterXML.jackson

xyuanlu commented on a change in pull request #1293:
URL: https://github.com/apache/helix/pull/1293#discussion_r473384110



##########
File path: helix-core/helix-core-1.0.2-SNAPSHOT.ivy
##########
@@ -53,8 +53,8 @@ under the License.
         <artifact name="slf4j-log4j12" ext="jar"/>
     </dependency>
     <dependency org="org.apache.zookeeper" name="zookeeper" rev="3.4.13" conf="compile->compile(default);runtime->runtime(default);default->default"/>
-    <dependency org="org.codehaus.jackson" name="jackson-core-asl" rev="1.8.5" conf="compile->compile(default);runtime->runtime(default);default->default"/>
-    <dependency org="org.codehaus.jackson" name="jackson-mapper-asl" rev="1.8.5" conf="compile->compile(default);runtime->runtime(default);default->default"/>
+		<dependency org="com.fasterxml.jackson.core" name="jackson-databind" rev="2.11.0" force="true" conf="compile->compile(*),master(*);runtime->runtime(*)"/>

Review comment:
       Ahh I copied from other ivy files.. I did not notice the difference between this one and others.. I will change it back to the old way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org